linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Huang Jianan <huangjianan@oppo.com>
Cc: Chengguang Xu <cgxu519@139.com>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	linux-erofs@lists.ozlabs.org, xiang@kernel.org, chao@kernel.org,
	guoweichao@oppo.com, yh@oppo.com, zhangshiming@oppo.com,
	guanyuwei@oppo.com, jnhuang95@gmail.com,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Chengguang Xu <cgxu519@mykernel.net>
Subject: Re: [PATCH v3] ovl: fix null pointer when filesystemdoesn'tsupportdirect IO
Date: Tue, 28 Sep 2021 09:17:23 +0200	[thread overview]
Message-ID: <CAJfpegsim-qtM4yaYdWo9P+QOP4UD_NrFTKADQky-HwOR=SPyQ@mail.gmail.com> (raw)
In-Reply-To: <97977a2c-28d5-1324-fb1e-3e23ab4b1340@oppo.com>

On Tue, 28 Sept 2021 at 09:01, Huang Jianan <huangjianan@oppo.com> wrote:
>
> 在 2021/9/27 17:38, Miklos Szeredi 写道:
> > On Wed, Sep 22, 2021 at 04:00:47PM +0200, Miklos Szeredi wrote:
> >
> >> First let's fix the oops: ovl_read_iter()/ovl_write_iter() must check
> >> real file's ->direct_IO if IOCB_DIRECT is set in iocb->ki_flags and
> >> return -EINVAL if not.
> > And here's that fix.  Please test.
>
> This patch can fix the oops.
>
> Tested-by: Huang Jianan <huangjianan@oppo.com>

Thanks for testing!

Miklos

      reply	other threads:[~2021-09-28  7:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-18 12:13 [PATCH] ovl: fix null pointer when filesystem doesn't support direct IO Huang Jianan
2021-09-22  1:56 ` Chengguang Xu
2021-09-22  3:39   ` Huang Jianan
2021-09-22  3:47 ` [PATCH v2] " Huang Jianan
2021-09-22  5:09   ` Chengguang Xu
2021-09-22  7:18     ` Huang Jianan
2021-09-22  7:23       ` [PATCH v3] " Huang Jianan
2021-09-22  8:06         ` Chengguang Xu
2021-09-22  8:24           ` Huang Jianan
2021-09-22 13:20             ` [PATCH v3] ovl: fix null pointer when filesystemdoesn'tsupportdirect IO Chengguang Xu
2021-09-22 14:00               ` Miklos Szeredi
2021-09-27  9:38                 ` Miklos Szeredi
2021-09-28  7:01                   ` Huang Jianan
2021-09-28  7:17                     ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegsim-qtM4yaYdWo9P+QOP4UD_NrFTKADQky-HwOR=SPyQ@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=cgxu519@139.com \
    --cc=cgxu519@mykernel.net \
    --cc=chao@kernel.org \
    --cc=guanyuwei@oppo.com \
    --cc=guoweichao@oppo.com \
    --cc=huangjianan@oppo.com \
    --cc=jnhuang95@gmail.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=xiang@kernel.org \
    --cc=yh@oppo.com \
    --cc=zhangshiming@oppo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).