linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Byron <ouyangxuan10@163.com>, Kevin Locke <kevin@kevinlocke.name>,
	overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: relax lookup error on mismatch origin ftype
Date: Wed, 21 Jul 2021 15:10:12 +0200	[thread overview]
Message-ID: <CAJfpegsxTjjBo08FfbuGqPPqrR71=c8SE97BiNyFnk-0D0Dgug@mail.gmail.com> (raw)
In-Reply-To: <20210427102826.1189410-1-amir73il@gmail.com>

On Tue, 27 Apr 2021 at 12:28, Amir Goldstein <amir73il@gmail.com> wrote:
>
> We get occasional reports of lookup errors due to mismatched
> origin ftype from users that re-format a lower squashfs image.
>
> Commit 13c6ad0f45fd ("ovl: document lower modification caveats")
> tries to discourage the practice of re-formating lower layers and
> describes the expected behavior as undefined.
>
> Commit b0e0f69731cd ("ovl: restrict lower null uuid for "xino=auto"")
> limits the configurations in which origin file handles are followed.
>
> In addition to these measures, change the behavior in case of detecting
> a mismatch origin ftype in lookup to issue a warning, not follow origin,
> but not fail the lookup operation either.
>
> That should make overall more users happy without any big consequences.
>
> Link: https://lore.kernel.org/linux-unionfs/CAOQ4uxgPq9E9xxwU2CDyHy-_yCZZeymg+3n+-6AqkGGE1YtwvQ@mail.gmail.com/
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
>
> Miklos,
>
> I am getting tired of dealing with lower squashfs related reports.
> How about this?
>
> It passes the xfstests quick tests and no, I do not have a reproducer
> for origin mismatch, so will wait for Byron to test the patch.

Pushed a simplified variant that just changes the
ovl_check_origin_fh() return value from -EIO to -ESTALE.   Do you see
a problem with this?

Thanks,
Miklos



>
> Thanks,
> Amir.
>
>  fs/overlayfs/namei.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/overlayfs/namei.c b/fs/overlayfs/namei.c
> index 71e264e2f16b..850c0a37f1f0 100644
> --- a/fs/overlayfs/namei.c
> +++ b/fs/overlayfs/namei.c
> @@ -392,7 +392,7 @@ int ovl_check_origin_fh(struct ovl_fs *ofs, struct ovl_fh *fh, bool connected,
>                             upperdentry, d_inode(upperdentry)->i_mode & S_IFMT,
>                             d_inode(origin)->i_mode & S_IFMT);
>         dput(origin);
> -       return -EIO;
> +       return -EINVAL;
>  }
>
>  static int ovl_check_origin(struct ovl_fs *ofs, struct dentry *upperdentry,
> @@ -408,7 +408,7 @@ static int ovl_check_origin(struct ovl_fs *ofs, struct dentry *upperdentry,
>         kfree(fh);
>
>         if (err) {
> -               if (err == -ESTALE)
> +               if (err == -ESTALE || err == -EINVAL)
>                         return 0;
>                 return err;
>         }
> --
> 2.25.1
>

  parent reply	other threads:[~2021-07-21 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-27 10:28 [PATCH] ovl: relax lookup error on mismatch origin ftype Amir Goldstein
     [not found] ` <123ca2cd.45f7.1792236c0e9.Coremail.ouyangxuan10@163.com>
2021-04-30 16:16   ` Amir Goldstein
     [not found]     ` <74a06ca.4928.17941146e4b.Coremail.ouyangxuan10@163.com>
2021-05-06 10:25       ` Amir Goldstein
     [not found]         ` <39ca38d.1ec8.17944f144b3.Coremail.ouyangxuan10@163.com>
2021-05-07  6:09           ` Amir Goldstein
2021-07-21 13:10 ` Miklos Szeredi [this message]
2021-07-21 14:16   ` Amir Goldstein
2021-07-21 14:33     ` Miklos Szeredi
2021-07-21 14:46       ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegsxTjjBo08FfbuGqPPqrR71=c8SE97BiNyFnk-0D0Dgug@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=kevin@kevinlocke.name \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=ouyangxuan10@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).