linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: linux-unionfs <linux-unionfs@vger.kernel.org>
Subject: Re: Mount failure caused by colon/comma characters in the path of lower/upper dirs
Date: Fri, 9 Jul 2021 16:03:11 +0200	[thread overview]
Message-ID: <CAJfpegsymMB5ni=GDQ+02u1OD-tzONkQy32bzjWyrOYq3VPf8w@mail.gmail.com> (raw)
In-Reply-To: <17a34811bb1.ca67d1a36094.7925246580859918166@mykernel.net>

On Tue, 22 Jun 2021 at 18:30, Chengguang Xu <cgxu519@mykernel.net> wrote:
>
> Hello,
>
> Today I got a mount failure report from a docker developer about special characters in overlayfs lower/upper path.
> The root cause is quite straightforward  because overlayfs uses colon/comma as seperator of lowerdir layers and module options.
> However, Colon/Comma characters are valid for directory name on linux so some people(especially container users) hope overlayfs
> could correctly recognize and handle those directories.
>
> Strengthen option parsing seems a right solution for fixing the issue, what do think for this?

Use backslash as an escape character.  E.g. lower directory named
"ab,cd:ef" needs to be passed to mount as "-olowerdir=ab\,cd\:ef"

Thanks,
Miklos

  reply	other threads:[~2021-07-09 14:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 16:15 Mount failure caused by colon/comma characters in the path of lower/upper dirs Chengguang Xu
2021-07-09 14:03 ` Miklos Szeredi [this message]
2021-07-10 14:22   ` Chengguang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegsymMB5ni=GDQ+02u1OD-tzONkQy32bzjWyrOYq3VPf8w@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=cgxu519@mykernel.net \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).