From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F20CDC64EC4 for ; Thu, 9 Mar 2023 15:32:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230430AbjCIPcA (ORCPT ); Thu, 9 Mar 2023 10:32:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbjCIPbz (ORCPT ); Thu, 9 Mar 2023 10:31:55 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EE92F2215 for ; Thu, 9 Mar 2023 07:31:39 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id u9so8636559edd.2 for ; Thu, 09 Mar 2023 07:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; t=1678375898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0DkXzgN0EHgf1dOpGSe3iIK1kwbBtYjaegg+rlUzVBc=; b=rdHTwYBJwTAOH3ZoXGlY/Fp2X/QNDdM0A9louBiy2i2xKkjSp8XnVIFYOQFSgO9Jbo 8z013P4W0b9argImTH3e4qOX0yhxpK5Ek+WB91F7tRSQbJTQdDRo6BiJbOCQvZ3y9pDc ioeOFqkSz9efsJ7Ls+hDktSxzsN5U4r2XK5S4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678375898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0DkXzgN0EHgf1dOpGSe3iIK1kwbBtYjaegg+rlUzVBc=; b=GLkRG3Xk/ICyUS5fZs9lgxGqV93fL695j9e7hHAjUaTSVJumzD7gS+5t6Y3UvRJX3d Us9Jd9yTPgfZAfzTWbSdrfyOI4rt/QdAYEZJviir6phOlJAjk34sr+oGBoIdKHtiS7O3 r3z+adZNSvnG8MG9bWlJGMaGgvFKENIF02GgLfoDM2e5ZFw1rMdByPEx1Qte5dYsO2+h tYUgj2vobOEfRioyP311qFuWcMNAEpGlsmPNyKlOJjnuaYVKVobF5AiFLJuQnmCf7Mj/ 5lSNC1UAFuBqom1YPlO68flZFQ4ZOgB+qy7Ev3BfgVbR9NYZ+7bxn2NOlg1OWmI+ZkFB J7dQ== X-Gm-Message-State: AO0yUKW9a0KfvwBGF3fNY1TgftA5cwHOkQ1BZgQDksA8Z8fh6tUYAKSv xrICeRcx5BS8JyTGbyU7o7HQxpqZKtFUMO66mgnRGg== X-Google-Smtp-Source: AK7set93nfCrfqMRpk5wPUF0BPSDl1IyaSI2laXoRcIFWebZUNfI5Dc9nDdr7AGuCpFt8SmT8ftKkp/Q8PN8wE40nmg= X-Received: by 2002:a17:906:5811:b0:877:747d:4a90 with SMTP id m17-20020a170906581100b00877747d4a90mr11456691ejq.14.1678375897972; Thu, 09 Mar 2023 07:31:37 -0800 (PST) MIME-Version: 1.0 References: <4B9D76D5-C794-4A49-A76F-3D4C10385EE0@kohlschutter.com> <83A29F9C-1A91-4753-953A-0C98E8A9832C@kohlschutter.com> <56E6CAAE-FF25-4898-8F9D-048164582E7B@kohlschutter.com> <490c5026-27bd-1126-65dd-2ec975aae94c@eitmlabs.org> In-Reply-To: From: Miklos Szeredi Date: Thu, 9 Mar 2023 16:31:27 +0100 Message-ID: Subject: Re: [PATCH] [REGRESSION] ovl: Handle ENOSYS when fileattr support is missing in lower/upper fs To: jonathan@eitm.org Cc: =?UTF-8?Q?Christian_Kohlsch=C3=BCtter?= , Linus Torvalds , overlayfs , linux-kernel , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org On Tue, 7 Mar 2023 at 18:14, Jonathan Katz wrote: > > On Tue, Mar 7, 2023 at 12:38=E2=80=AFAM Miklos Szeredi wrote: > > > > On Tue, 7 Mar 2023 at 02:12, Jonathan Katz wrote: > > > > > > Hi all, > > > > > > In pursuing this issue, I downloaded the kernel source to see if I > > > could debug it further. In so doing, it looks like Christian's patch > > > was never committed to the main source tree (sorry if my terminology > > > is wrong). This is up to and including the 6.3-rc1. I could also > > > find no mention of the fix in the log. > > > > > > I am trying to manually apply this patch now, but, I am wondering if > > > there was some reason that it was not applied (e.g. it introduces som= e > > > instability?)? > > > > It's fixing the bug in the wrong place, i.e. it's checking for an > > -ENOSYS return from vfs_fileattr_get(), but that return value is not > > valid at that point. > > > > The right way to fix this bug is to prevent -ENOSYS from being > > returned in the first place. > > > > Commit 02c0cab8e734 ("fuse: ioctl: translate ENOSYS") fixes one of > > those bugs, but of course it's possible that I missed something in > > that fix. > > > > Can you please first verify that an upstream kernel (>v6.0) can also > > reproduce this issue? > > Got ya. that makes a lot of sense, thank you. > > I have confirmed that I continue to get the error with 6.2 . > quick summary of the lowerdir: > server ---- NFS(ro) ---- > client "/nfs" > client "/nfs" --- bindfs(uidmap) --- > client "/lower" Can you please run bindfs in debugging mode (-d) and send the resulting log after reproducing the issue? Thanks, Miklos