($INBOX_DIR/description missing)
 help / color / Atom feed
* [RFC PATCH] ovl: do not copy attr several times
@ 2021-02-26  9:24 Chengguang Xu
  2021-03-24 16:00 ` Miklos Szeredi
  0 siblings, 1 reply; 2+ messages in thread
From: Chengguang Xu @ 2021-02-26  9:24 UTC (permalink / raw)
  To: miklos; +Cc: linux-unionfs, Chengguang Xu

In ovl_xattr_set() we have already copied attr of real inode
so no need to copy it again in ovl_posix_acl_xattr_set().

Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
---
 fs/overlayfs/super.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index d58b8f2bf9d0..c61f42c901d1 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -1035,9 +1035,6 @@ ovl_posix_acl_xattr_set(const struct xattr_handler *handler,
 	}
 
 	err = ovl_xattr_set(dentry, inode, handler->name, value, size, flags);
-	if (!err)
-		ovl_copyattr(ovl_inode_real(inode), inode);
-
 	return err;
 
 out_acl_release:
-- 
2.27.0



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFC PATCH] ovl: do not copy attr several times
  2021-02-26  9:24 [RFC PATCH] ovl: do not copy attr several times Chengguang Xu
@ 2021-03-24 16:00 ` Miklos Szeredi
  0 siblings, 0 replies; 2+ messages in thread
From: Miklos Szeredi @ 2021-03-24 16:00 UTC (permalink / raw)
  To: Chengguang Xu; +Cc: overlayfs

On Fri, Feb 26, 2021 at 10:25 AM Chengguang Xu <cgxu519@mykernel.net> wrote:
>
> In ovl_xattr_set() we have already copied attr of real inode
> so no need to copy it again in ovl_posix_acl_xattr_set().

Thanks, applied.

Miklos

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-26  9:24 [RFC PATCH] ovl: do not copy attr several times Chengguang Xu
2021-03-24 16:00 ` Miklos Szeredi

($INBOX_DIR/description missing)

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-unionfs/0 linux-unionfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-unionfs linux-unionfs/ https://lore.kernel.org/linux-unionfs \
		linux-unionfs@vger.kernel.org
	public-inbox-index linux-unionfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-unionfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git