linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Fabian <godi.beat@gmx.net>, overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: fix regression with re-formatted lower squashfs
Date: Tue, 14 Jul 2020 16:27:51 +0200	[thread overview]
Message-ID: <CAJfpegu928w_58qc=1-MDfK559Xu4z_pHxz_caaYFmWbX7iO=w@mail.gmail.com> (raw)
In-Reply-To: <20200708131613.30038-1-amir73il@gmail.com>

On Wed, Jul 8, 2020 at 3:16 PM Amir Goldstein <amir73il@gmail.com> wrote:
>
> Commit 9df085f3c9a2 ("ovl: relax requirement for non null uuid of lower
> fs") relaxed the requirement for non null uuid with single lower layer to
> allow enabling index and nfs_export features with single lower squashfs.
>
> Fabian reported a regression in a setup when overlay re-uses an existing
> upper layer and re-formats the lower squashfs image.  Because squashfs
> has no uuid, the origin xattr in upper layer are decoded from the new
> lower layer where they may resolve to a wrong origin file and user may
> get an ESTALE or EIO error on lookup.
>
> To avoid the reported regression while still allowing the new features
> with single lower squashfs, do not allow decoding origin with lower null
> uuid unless user opted-in to one of the new features that require
> following the lower inode of non-dir upper (index, xino, metacopy).
>
> Reported-by: Fabian <godi.beat@gmx.net>
> Link: https://lore.kernel.org/linux-unionfs/32532923.JtPX5UtSzP@fgdesktop/
> Fixes: 9df085f3c9a2 ("ovl: relax requirement for non null uuid...")
> Cc: stable@vger.kernel.org # v4.20+
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>


Thanks, applied.

Miklos

      reply	other threads:[~2020-07-14 14:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 13:16 [PATCH] ovl: fix regression with re-formatted lower squashfs Amir Goldstein
2020-07-14 14:27 ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegu928w_58qc=1-MDfK559Xu4z_pHxz_caaYFmWbX7iO=w@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=godi.beat@gmx.net \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).