archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <>
To: Chengguang Xu <>
Cc: overlayfs <>
Subject: Re: [PATCH] ovl: copy-up optimization for truncate
Date: Mon, 29 Mar 2021 17:13:52 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Mon, Mar 8, 2021 at 12:17 PM Chengguang Xu <> wrote:
> Currently copy-up will copy whole lower file to upper
> regardless of the data range which is needed for further
> operation. This patch avoids unnecessary copy when truncate
> size is smaller than the file size.

This doesn't look right.   If copy up succeeds, resulting in a
truncated file, then we should return success there and then.   Doing
the truncate again and failing (unlikely, but I wouldn't think it
impossible) wouldn't be nice.

But need to be careful, because we could possibly have other attribute
change requests besides ATTR_SIZE, in which case optimizing the
truncate away and returning success wouldn't be correct.

Minor issue: this patch doesn't optimize the truncate to zero case.
That's not a bug, but I'm curious if that is an oversight or


  parent reply	other threads:[~2021-03-29 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 11:17 [PATCH] ovl: copy-up optimization for truncate Chengguang Xu
2021-03-08 12:09 ` Amir Goldstein
2021-03-29 15:13 ` Miklos Szeredi [this message]
2021-03-30  7:17   ` Chengguang Xu
2021-04-01 11:15   ` Chengguang Xu
2021-04-01 11:31     ` Miklos Szeredi
2021-04-01 12:39       ` Chengguang Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).