linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Chris Murphy <lists@colorremedies.com>,
	overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: invalidate readdir cache on changes to dir with origin
Date: Mon, 12 Apr 2021 10:10:36 +0200	[thread overview]
Message-ID: <CAJfpeguY0znQOqcwyTe-Md8hDBtktwA=XWcGSymFU6me7=Dp+Q@mail.gmail.com> (raw)
In-Reply-To: <20210411092223.1914782-1-amir73il@gmail.com>

On Sun, Apr 11, 2021 at 11:22 AM Amir Goldstein <amir73il@gmail.com> wrote:
>
> The test in ovl_dentry_version_inc() was out-dated and did not include
> the case where readdir cache is used on a non-merge dir that has origin
> xattr, indicating that it may contain leftover whiteouts.
>
> To make the code more robust, use the same helper ovl_dir_is_real()
> to determine if readdir cache should be used and if readdir cache should
> be invalidated.

Makes sense, applied.

Thanks,
Miklos

      reply	other threads:[~2021-04-12  8:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-11  9:22 [PATCH] ovl: invalidate readdir cache on changes to dir with origin Amir Goldstein
2021-04-12  8:10 ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpeguY0znQOqcwyTe-Md8hDBtktwA=XWcGSymFU6me7=Dp+Q@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=lists@colorremedies.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).