linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Amir Goldstein <amir73il@gmail.com>
Cc: linux-unionfs@vger.kernel.org
Subject: Re: [PATCH 0/2] Performance improvements for ovl_indexdir_cleanup()
Date: Thu, 6 Oct 2022 14:21:21 +0200	[thread overview]
Message-ID: <CAJfpeguemhcaGub8PkovtWQ-yR0y7ZRBwPRqYi99vUZWcWM5zA@mail.gmail.com> (raw)
In-Reply-To: <20221004103433.966743-1-amir73il@gmail.com>

On Tue, 4 Oct 2022 at 12:34, Amir Goldstein <amir73il@gmail.com> wrote:
>
> Miklos,
>
> I ran into an incident of very large index dir which took considerable
> amount of time to mount the indexed overlay (~30 minutes).
> The index dir had millions of entries and I do not think that the use
> case that caused this is typical.
>
> The following two patches are based on perf top analysis of this
> incident.  I do not have access to the data set that caused the
> very long mount time, but I tested the desired CPU usage improvements
> on a smaller scale data set.
>
> It is hard to say if this extreme case of very large index dir is
> common enough to be worth any attention, so I did not tag the fixes
> for stable and I don't think it is urgent to apply them.
>
> Unfortunattely, the investigation of the incident was not timed
> optimally w.r.t. to the current merge window.
> Nevertheless, the changes are quite trivial, so you may want to consider
> them either for -rc or for next release.

Looks good.  Pushed to #overlayfs-next.

Thanks,
Miklos

      parent reply	other threads:[~2022-10-06 12:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 10:34 [PATCH 0/2] Performance improvements for ovl_indexdir_cleanup() Amir Goldstein
2022-10-04 10:34 ` [PATCH 1/2] ovl: do not reconnect upper index records in ovl_indexdir_cleanup() Amir Goldstein
2022-10-04 10:34 ` [PATCH 2/2] ovl: use plain list filler in indexdir and workdir cleanup Amir Goldstein
2022-10-06 12:21 ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJfpeguemhcaGub8PkovtWQ-yR0y7ZRBwPRqYi99vUZWcWM5zA@mail.gmail.com \
    --to=miklos@szeredi.hu \
    --cc=amir73il@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).