From: Miklos Szeredi <miklos@szeredi.hu>
To: Chengguang Xu <cgxu519@139.com>
Cc: Chengguang Xu <cgxu519@mykernel.net>, Jan Kara <jack@suse.cz>,
Amir Goldstein <amir73il@gmail.com>,
linux-fsdevel@vger.kernel.org,
overlayfs <linux-unionfs@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v5 07/10] ovl: cache dirty overlayfs' inode
Date: Thu, 7 Oct 2021 14:27:23 +0200 [thread overview]
Message-ID: <CAJfpegujsoyXEQR4CBH3koZdpe+qUVj3R6Okt+3k9AbvUPohJQ@mail.gmail.com> (raw)
In-Reply-To: <3b660f79-9f60-5acd-0b9a-47f9e3e6a04b@139.com>
On Thu, 7 Oct 2021 at 14:04, Chengguang Xu <cgxu519@139.com> wrote:
>
> 在 2021/10/7 19:09, Miklos Szeredi 写道:
> > On Thu, 23 Sept 2021 at 15:08, Chengguang Xu <cgxu519@mykernel.net> wrote:
> >> Now drop overlayfs' inode will sync dirty data,
> >> so we change to only drop clean inode.
> >>
> >> The purpose of doing this is to keep compatible
> >> behavior with before because without this change
> >> dropping overlayfs inode will not trigger syncing
> >> of underlying dirty inode.
> >>
> >> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
> >> ---
> >> fs/overlayfs/super.c | 16 +++++++++++++++-
> >> 1 file changed, 15 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
> >> index cddae3ca2fa5..bf4000eb9be8 100644
> >> --- a/fs/overlayfs/super.c
> >> +++ b/fs/overlayfs/super.c
> >> @@ -441,11 +441,25 @@ static int ovl_write_inode(struct inode *inode,
> >> return ret;
> >> }
> >>
> >> +/*
> >> + * In iput_final(), clean inode will drop directly and dirty inode will
> >> + * keep in the cache until write back to sync dirty data then add to lru
> >> + * list to wait reclaim.
> >> + */
> >> +static int ovl_drop_inode(struct inode *inode)
> >> +{
> >> + struct inode *upper = ovl_inode_upper(inode);
> >> +
> >> + if (!upper || !(inode->i_state & I_DIRTY_ALL))
> > Could we check upper dirtyness here? That would give a more precise result.
>
> We keep tracking mmapped-file(shared mode) by explicitely marking
> overlay inode dirty,
>
> so if we drop overlay inode by checking upper dirtyness, we may lose
> control on those mmapped upper inodes.
That's fine, since there are no more mmaps at this point.
> >
> > Alternatively don't set .drop_inode (i.e. use generic_drop_inode())
> > and set I_DONTCACHE on overlay inodes. That would cause the upper
> > inode to be always written back before eviction.
> >
> > The latter would result in simpler logic, and I think performance-wise
> > it wouldn't matter. But I may be missing something.
>
> I think we may seperate mmapped-file(shared) inode and other inode by
>
> clear/set I_DONTCACHE flag on overlay inode if you prefer this approach.
Same reasoning here: after upper inode is written out, the dirtyness
in the overlay inode doesn't matter since there cannot be any active
mmaps.
Thanks,
Miklos
next prev parent reply other threads:[~2021-10-07 12:27 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 13:08 [RFC PATCH v5 00/10] implement containerized syncfs for overlayfs Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 01/10] ovl: setup overlayfs' private bdi Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 02/10] ovl: implement ->writepages operation Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 03/10] ovl: implement overlayfs' ->evict_inode operation Chengguang Xu
2021-10-06 15:33 ` Miklos Szeredi
2021-10-07 6:08 ` Chengguang Xu
2021-10-07 7:43 ` Miklos Szeredi
2021-09-23 13:08 ` [RFC PATCH v5 04/10] ovl: mark overlayfs' inode dirty on modification Chengguang Xu
2021-10-07 18:43 ` Miklos Szeredi
2021-09-23 13:08 ` [RFC PATCH v5 05/10] ovl: mark overlayfs' inode dirty on shared mmap Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 06/10] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2021-10-07 9:01 ` Jan Kara
2021-10-07 12:26 ` Chengguang Xu
2021-10-07 14:41 ` Jan Kara
2021-10-07 14:54 ` Chengguang Xu
2021-10-07 9:23 ` Miklos Szeredi
2021-10-07 12:28 ` Chengguang Xu
2021-10-07 12:45 ` Miklos Szeredi
2021-10-07 13:09 ` Chengguang Xu
2021-10-07 13:34 ` Miklos Szeredi
2021-10-07 14:46 ` Jan Kara
2021-10-07 14:53 ` Chengguang Xu
2021-10-07 18:51 ` Miklos Szeredi
2021-10-08 13:13 ` Jan Kara
2021-11-16 2:20 ` Chengguang Xu
2021-11-16 12:35 ` Miklos Szeredi
2021-11-17 6:11 ` Chengguang Xu
2021-11-18 6:32 ` Chengguang Xu
2021-11-18 11:23 ` Jan Kara
2021-11-18 12:02 ` Chengguang Xu
2021-11-18 16:43 ` Jan Kara
2021-11-19 6:12 ` Chengguang Xu
2021-11-30 11:22 ` Jan Kara
2021-11-30 16:09 ` Chengguang Xu
2021-11-30 19:04 ` Amir Goldstein
2021-12-01 2:37 ` Chengguang Xu
2021-12-01 6:31 ` Chengguang Xu
2021-12-01 7:19 ` Amir Goldstein
2021-12-01 13:46 ` Jan Kara
2021-12-01 14:59 ` Chengguang Xu
2021-12-01 16:24 ` Chengguang Xu
2021-12-01 22:47 ` Amir Goldstein
2021-12-01 23:23 ` ovl_flush() behavior Amir Goldstein
2021-12-02 2:11 ` Chengguang Xu
2021-12-02 15:20 ` Vivek Goyal
2021-12-02 15:59 ` Amir Goldstein
2021-12-02 22:00 ` Vivek Goyal
2021-12-02 15:14 ` Vivek Goyal
2021-12-05 14:06 ` [RFC PATCH v5 06/10] ovl: implement overlayfs' ->write_inode operation Chengguang Xu
2021-12-07 5:33 ` Amir Goldstein
2022-02-05 16:09 ` Chengguang Xu
2022-02-05 16:23 ` Amir Goldstein
2021-09-23 13:08 ` [RFC PATCH v5 07/10] ovl: cache dirty overlayfs' inode Chengguang Xu
2021-10-07 11:09 ` Miklos Szeredi
2021-10-07 12:04 ` Chengguang Xu
2021-10-07 12:27 ` Miklos Szeredi [this message]
2021-09-23 13:08 ` [RFC PATCH v5 08/10] fs: export wait_sb_inodes() Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 09/10] fs: introduce new helper sync_fs_and_blockdev() Chengguang Xu
2021-10-19 7:15 ` Amir Goldstein
2021-11-15 11:39 ` Chengguang Xu
2021-09-23 13:08 ` [RFC PATCH v5 10/10] ovl: implement containerized syncfs for overlayfs Chengguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJfpegujsoyXEQR4CBH3koZdpe+qUVj3R6Okt+3k9AbvUPohJQ@mail.gmail.com \
--to=miklos@szeredi.hu \
--cc=amir73il@gmail.com \
--cc=cgxu519@139.com \
--cc=cgxu519@mykernel.net \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).