From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87DA5C433B4 for ; Tue, 13 Apr 2021 08:43:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69D9C613AE for ; Tue, 13 Apr 2021 08:43:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242957AbhDMIoA (ORCPT ); Tue, 13 Apr 2021 04:44:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbhDMIn7 (ORCPT ); Tue, 13 Apr 2021 04:43:59 -0400 Received: from mail-ua1-x929.google.com (mail-ua1-x929.google.com [IPv6:2607:f8b0:4864:20::929]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B67ACC061574 for ; Tue, 13 Apr 2021 01:43:38 -0700 (PDT) Received: by mail-ua1-x929.google.com with SMTP id q18so5069166uas.11 for ; Tue, 13 Apr 2021 01:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=CJTfxw+7T+FVtf/ZtoDIPSgRwAfJ87Xex1gXOvrotkg=; b=KPTes4bLsDcgFD2oHlgu+gfedwOnhP/gsDS/PcoU5t7cE8/zPxqpf7pmG2PCWiAosD UPs+6nVeZnJWAZtrphx8oAtjP/UeMJ7+QS1Arun3o+sFaFce8Q4G8YMEq9qvFnATaWmr cBEZb9zhn1FDM2dbKOiz5gimWqISrkY7SOQDE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=CJTfxw+7T+FVtf/ZtoDIPSgRwAfJ87Xex1gXOvrotkg=; b=jXBtC4HUTJvslH63XYpV5BoQDAEv9W2uiCTGywLUONN51W4eYFWkjdxukIYGqgCz4E WcfOv+Mtwrwsq9GRNbYpnKVp0kfeNKlbQiVBiPAs9GpWN30QVuZYcaCkOVH8gIXsIsdZ SERz0/B5nofcees4UGucnCn8cB0F2JPXWM7kIKf09JKbaQ8iNL383xU4rt02RquNF34i ZgChzvon3FEHeIbAjkVBo8DR17T+NNeRK/AwSOiS79F2QkFZ9XH/UP6K/nTKZkJ2vyt7 Uifo9q/4ACvaROM38fVb8xe5Qlg/HNfu8XMa0pxoKBaBaEoiMcrvj26rHPycD3/yymfX 5joA== X-Gm-Message-State: AOAM5335NOqprZtSPxS8ONsh8ehyadK7XBVHoyROWOGqrQugOOBCr1qh E2Wg2se0EaqCilu61PdMnspxSW6fqSKrQzHf5xJ+fg== X-Google-Smtp-Source: ABdhPJxf/jIC/3VGIYg9aumcXX/Hfbj7+H0VyKvsphMSy5GaTiEb+ozMw2EVHFtGRzrysJV/3wpSrOnSVlq2XCpzuzQ= X-Received: by 2002:ab0:596f:: with SMTP id o44mr22269909uad.8.1618303417875; Tue, 13 Apr 2021 01:43:37 -0700 (PDT) MIME-Version: 1.0 References: <20201113065555.147276-1-cgxu519@mykernel.net> <20201113065555.147276-8-cgxu519@mykernel.net> <178c901d7ad.fdc7d65c21509.6849935952336944935@mykernel.net> In-Reply-To: <178c901d7ad.fdc7d65c21509.6849935952336944935@mykernel.net> From: Miklos Szeredi Date: Tue, 13 Apr 2021 10:43:27 +0200 Message-ID: Subject: Re: [RFC PATCH v4 7/9] ovl: cache dirty overlayfs' inode To: Chengguang Xu Cc: Jan Kara , Amir Goldstein , overlayfs , linux-fsdevel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-unionfs@vger.kernel.org On Tue, Apr 13, 2021 at 4:14 AM Chengguang Xu wrote: > > ---- =E5=9C=A8 =E6=98=9F=E6=9C=9F=E4=BA=94, 2021-04-09 21:50:35 Miklos S= zeredi =E6=92=B0=E5=86=99 ---- > > On Fri, Nov 13, 2020 at 7:57 AM Chengguang Xu w= rote: > > > > > > Now drop overlayfs' inode will sync dirty data, > > > so we change to only drop clean inode. > > > > I don't understand what happens here. Please add more explanation. > > In iput_final(), clean overlayfs inode will directly drop as the same as = before, > dirty overlayfs inode will keep in the cache to wait writeback to sync di= rty data > and then add to lru list to wait reclaim. > > The purpose of doing this is to keep compatible behavior with original on= e, > because without this series, dropping overlayfs inode will not trigger sy= ncing > underlying dirty inode. I get it now. Can you please update the patch header with this description= ? Thanks, Miklos