linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Miklos Szeredi <miklos@szeredi.hu>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: update ctime when changing file attribution
Date: Wed, 21 Jul 2021 15:11:20 +0200	[thread overview]
Message-ID: <CAJfpegvvPoVpWLBTC-caM9EJp4kAbCTf=drgeSWbVQa1XWHRXA@mail.gmail.com> (raw)
In-Reply-To: <20210310020925.2441670-1-cgxu519@mykernel.net>

On Wed, 10 Mar 2021 at 03:09, Chengguang Xu <cgxu519@mykernel.net> wrote:
>
> Currently we keep size, mode and times of overlay inode
> as the same as upper inode, so should update ctime when
> changing file attribution as well.

Updated and pushed.

Thanks,
Miklos

>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
> ---
>  fs/overlayfs/file.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
> index dbfb35fb0ff7..49b73a2e92a7 100644
> --- a/fs/overlayfs/file.c
> +++ b/fs/overlayfs/file.c
> @@ -546,6 +546,8 @@ static long ovl_ioctl_set_flags(struct file *file, unsigned int cmd,
>         ret = ovl_real_ioctl(file, cmd, arg);
>
>         ovl_copyflags(ovl_inode_real(inode), inode);
> +       /* Update ctime */
> +       ovl_copyattr(ovl_inode_real(inode), inode);
>  unlock:
>         inode_unlock(inode);
>
> --
> 2.27.0
>
>

      reply	other threads:[~2021-07-21 13:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10  2:09 [PATCH] ovl: update ctime when changing file attribution Chengguang Xu
2021-07-21 13:11 ` Miklos Szeredi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJfpegvvPoVpWLBTC-caM9EJp4kAbCTf=drgeSWbVQa1XWHRXA@mail.gmail.com' \
    --to=miklos@szeredi.hu \
    --cc=cgxu519@mykernel.net \
    --cc=linux-unionfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).