linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Eryu Guan <guaneryu@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] overlay: add test for copy up of lower file attributes
Date: Tue, 3 Aug 2021 10:21:02 +0300	[thread overview]
Message-ID: <CAOQ4uxgC6R9rAEM8YfJ83SN2UN_Z9gKY3_CTdDaYayC7SoNe4Q@mail.gmail.com> (raw)
In-Reply-To: <20210802230727.GC3601425@magnolia>

On Tue, Aug 3, 2021 at 2:07 AM Darrick J. Wong <djwong@kernel.org> wrote:
>
> On Thu, Jul 22, 2021 at 07:46:34PM +0300, Amir Goldstein wrote:
> > Overlayfs copies up a subset of lower file attributes since kernel
> > commits:
> > 173ff5c9ec37 ("ovl: consistent behavior for immutable/append-only inodes")
> > 2e3f6e87c2b0 ("ovl: copy up sync/noatime fileattr flags")
> >
> > This test verifies this functionality works correctly and that it
> > survives power failure and/or mount cycle.
>
> Just out of curiosity -- is this supposed to succeed with a 5.14-rc4
> kernel?

No. The documented fix commits are in linux-next.
Looks like they are heading for 5.15-rc1.

> I noticed a massive regression with this week's fstests,
> probably because something didn't get cleaned up properly:
>
> --- overlay/078.out
> +++ overlay/078.out.bad
> @@ -1,2 +1,17 @@
>  QA output created by 078
>  Silence is golden
> +Before copy up: -------A-------------- /opt/ovl-mnt/testfile
> +After  copy up: ---------------------- /opt/ovl-mnt/testfile
> +Before copy up: -------A-------------- /opt/ovl-mnt/testfile
> +After  copy up: ---------------------- /opt/ovl-mnt/testfile
> +Before copy up: --S----A-------------- /opt/ovl-mnt/testfile
> +After  copy up: ---------------------- /opt/ovl-mnt/testfile
> +Before copy up: --S----A-------------- /opt/ovl-mnt/testfile
> +After  copy up: ---------------------- /opt/ovl-mnt/testfile
> +Before copy up: --S--a-A-------------- /opt/ovl-mnt/testfile
> +After  copy up: ---------------------- /opt/ovl-mnt/testfile
> +Before copy up: --S--a-A-------------- /opt/ovl-mnt/testfile
> +After  copy up: ---------------------- /opt/ovl-mnt/testfile
> +rm: cannot remove '/opt/ovl-upper/testfile': Operation not permitted
> +rm: cannot remove
> '/opt/ovl-work/index/00fb2100812f1a30dc474847dbad5281308293ece9030e00020000000054816fd1':

I'm curious, are you running with non-default mount/config options
on purpose? i.e. index=on or nfs_export=on?

> Operation not permitted
> +Write unexpectedly returned 0 for file with attribute 'i'

Oops, sorry. The problem is even sooner than _cleanup().
I hadn't noticed it because the head snippet of 078.out.bad was expected
and I did not look past it.

>
> and then the tests after it (e.g. generic/030) fail with:
>
> +mount: /opt/ovl-mnt: mount(2) system call failed: Stale file handle.
> +mount failed
> +(see /var/tmp/fstests/generic/030.full for details)
>

And I hadn't noticed that because overlay/078 is the last test to reuse
/opt/ovl-upper/ and kvm-xfstests zaps the base fs before every run.

Posted a fix.
Sorry for the trouble.

Thanks,
Amir.

  reply	other threads:[~2021-08-03  7:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-22 16:46 [PATCH] overlay: add test for copy up of lower file attributes Amir Goldstein
2021-07-25 16:27 ` Eryu Guan
2021-07-25 18:21   ` Amir Goldstein
2021-07-26  3:13     ` Eryu Guan
2021-08-02 23:07 ` Darrick J. Wong
2021-08-03  7:21   ` Amir Goldstein [this message]
2021-08-04  3:44     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxgC6R9rAEM8YfJ83SN2UN_Z9gKY3_CTdDaYayC7SoNe4Q@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=djwong@kernel.org \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).