linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>, Chao Yu <yuchao0@huawei.com>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] generic/507: support more filesystems
Date: Sun, 13 Jun 2021 09:34:11 +0300	[thread overview]
Message-ID: <CAOQ4uxgdZqBv6ju+6HLXSPh1N5X+pzBXTB+0uhZw2dFhTs1ESA@mail.gmail.com> (raw)
In-Reply-To: <20210611131029.679307-1-amir73il@gmail.com>

On Fri, Jun 11, 2021 at 4:10 PM Amir Goldstein <amir73il@gmail.com> wrote:
>
> The commit message introducing the test says:
> "We only check below attribute modification which most filesystem
>  supports:
>     - no atime updates (A)
>     - secure deletion (s)
>     - synchronous updates (S)
>     - undeletable (u)
> "
> But in fact, very few filesystems support the (s) and (u) flags.
> xfs and btrfs do not support them for example.
>
> The test doesn't need to check those specific flags, so replace those
> flags with immutable (i) and append-only (a), which most filesystems
> really do support.
>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
>
> Eryu,
>
> This would be a good test to cover the recent fileattr vfs changes
> by Miklos that changed the implementation of SETFLAGS ioctl in all the
> filesystem, only the test does not run on most of the filesystems...
>
> Thanks,
> Amir.
>
>  tests/generic/507 | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tests/generic/507 b/tests/generic/507
> index b654883a..cc61b3cb 100755
> --- a/tests/generic/507
> +++ b/tests/generic/507
> @@ -9,7 +9,7 @@
>  # i_flags can be recovered after sudden power-cuts.
>  # 1. touch testfile;
>  # 1.1 sync (optional)
> -# 2. chattr +[AsSu] testfile
> +# 2. chattr +[ASai] testfile

I missed the same fix that's needed in line 8. below...

>  # 3. xfs_io -f testfile -c "fsync";
>  # 4. godown;
>  # 5. umount;
> @@ -34,6 +34,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>  _cleanup()
>  {
>         cd /
> +       $CHATTR_PROG -ai $testfile &> /dev/null
>         rm -f $tmp.*
>  }
>
> @@ -49,7 +50,7 @@ _supported_fs generic
>
>  _require_command "$LSATTR_PROG" lasttr
>  _require_command "$CHATTR_PROG" chattr
> -_require_chattr AsSu
> +_require_chattr ASai
>
>  _require_scratch
>  _require_scratch_shutdown
> @@ -79,7 +80,7 @@ do_check()
>
>         before=`$LSATTR_PROG $testfile`
>
> -       $XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io
> +       $XFS_IO_PROG -r -f $testfile -c "fsync" | _filter_xfs_io
>
>         _scratch_shutdown | tee -a $seqres.full
>         _scratch_cycle_mount
> @@ -101,7 +102,7 @@ do_check()
>
>         before=`$LSATTR_PROG $testfile`
>
> -       $XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io
> +       $XFS_IO_PROG -r -f $testfile -c "fsync" | _filter_xfs_io
>
>         _scratch_shutdown | tee -a $seqres.full
>         _scratch_cycle_mount
> @@ -122,7 +123,7 @@ do_check()
>
>  echo "Silence is golden"
>
> -opts="A s S u"
> +opts="A S a i"
>  for i in $opts; do
>         do_check $i
>         do_check $i sync
> --
> 2.31.1
>

  reply	other threads:[~2021-06-13  6:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-11 13:10 Amir Goldstein
2021-06-13  6:34 ` Amir Goldstein [this message]
2021-06-13 15:40   ` Eryu Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxgdZqBv6ju+6HLXSPh1N5X+pzBXTB+0uhZw2dFhTs1ESA@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=yuchao0@huawei.com \
    --subject='Re: [PATCH] generic/507: support more filesystems' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).