($INBOX_DIR/description missing)
 help / color / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
	Miklos Szeredi <mszeredi@redhat.com>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 4/4] ovl: alllow remote upper
Date: Mon, 16 Mar 2020 21:02:32 +0200
Message-ID: <CAOQ4uxgfTJwE2O1GGt-TY+6ijjKE13+ATTarijFGLiM69jk8HA@mail.gmail.com> (raw)
In-Reply-To: <20200316175453.GB4013@redhat.com>

On Mon, Mar 16, 2020 at 8:15 PM Vivek Goyal <vgoyal@redhat.com> wrote:
>
> On Sat, Mar 14, 2020 at 03:16:28PM +0200, Amir Goldstein wrote:
> > On Thu, Feb 20, 2020 at 10:00 PM Amir Goldstein <amir73il@gmail.com> wrote:
> > >
> > > On Thu, Feb 20, 2020 at 9:52 AM Amir Goldstein <amir73il@gmail.com> wrote:
> > > >
> > > > On Tue, Feb 4, 2020 at 7:02 PM Amir Goldstein <amir73il@gmail.com> wrote:
> > > > >
> > > > > On Tue, Feb 4, 2020 at 6:17 PM Miklos Szeredi <miklos@szeredi.hu> wrote:
> > > > > >
> > > > > > On Tue, Feb 4, 2020 at 3:59 PM Vivek Goyal <vgoyal@redhat.com> wrote:
> > > > > > >
> > > > > > > On Fri, Jan 31, 2020 at 12:50:04PM +0100, Miklos Szeredi wrote:
> > > > > > > > No reason to prevent upper layer being a remote filesystem.  Do the
> > > > > > > > revalidation in that case, just as we already do for lower layers.
> > > > > > > >
> > > > > > > > This lets virtiofs be used as upper layer, which appears to be a real use
> > > > > > > > case.
> > > > > > >
> > > > > > > Hi Miklos,
> > > > > > >
> > > > > > > I have couple of very basic questions.
> > > > > > >
> > > > > > > - So with this change, we will allow NFS to be upper layer also?
> > > > > >
> > > > > > I haven't tested, but I think it will fail on the d_type test.
> > > > >
> > > > > But we do not fail mount on no d_type support...
> > > > > Besides, I though you were going to add the RENAME_WHITEOUT
> > > > > test to avert untested network fs as upper.
> > > > >
> > > >
> > > > Pushed strict remote upper check to:
> > > > https://github.com/amir73il/linux/commits/ovl-strict-upper
> > > >
> >
> > Vivek,
> >
> > Could you please make sure that the code in ovl-strict-upper branch
> > works as expected for virtio as upper fs?
>
> Hi Amir,
>
> Right now it fails becuase virtiofs doesn't seem to support tmpfile yet.
>
> overlayfs: upper fs does not support tmpfile
> overlayfs: upper fs missing required features.
>
> Will have to check what's required to support it.
>
> I also wanted to run either overlay xfstests or unionmount-testsuite. But
> none of these seem to give me enough flexibility where I can specify
> that overlayfs needs to be mounted on top of virtiofs.
>
> I feel that atleast for unionmount-testsuite, there should be an
> option where we can simply give a target directory and tests run
> on that directory and user mounts that directory as needed.
>

Need to see how patches look.
Don't want too much configuration complexity, but I agree that some
flexibly is needed.
Maybe the provided target directory should be the upper/work basedir?

> > I have rebased it on latest overlayfs-next merge into current master.
> >
> > I would very much prefer that the code merged to v5.7-rc1 will be more
> > restrictive than the current overlayfs-next.
>
> In general I agree that if we want to not support some configuration
> with remote upper, this is the time to introduce that restriction
> otherwise we will later run into backward compatibility issue.
>
> Having said that, tmpfile support for upper sounds like a nice to
> have feature. Not sure why to make it mandatory.
>

Agreed, I just went automatic on all the warnings.
tmpfile should not be a requirement for upper.
Could you please verify that if dropping the tmpfile strict check,
virtio can be used as upper.

Thanks,
Amir.

  reply index

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 11:50 [PATCH 0/4] ovl: allow virtiofs as upper Miklos Szeredi
2020-01-31 11:50 ` [PATCH 1/4] ovl: restructure dentry revalidation Miklos Szeredi
2020-01-31 11:50 ` [PATCH 2/4] ovl: separate detection of remote upper layer from stacked overlay Miklos Szeredi
2020-01-31 11:50 ` [PATCH 3/4] ovl: decide if revalidate needed on a per-dentry bases Miklos Szeredi
2020-01-31 14:53   ` Amir Goldstein
2020-01-31 15:15     ` Miklos Szeredi
2020-01-31 11:50 ` [PATCH 4/4] ovl: alllow remote upper Miklos Szeredi
2020-01-31 15:29   ` Amir Goldstein
2020-01-31 15:38     ` Miklos Szeredi
2020-01-31 15:50       ` Amir Goldstein
2020-01-31 16:05         ` Miklos Szeredi
2020-02-04 14:59   ` Vivek Goyal
2020-02-04 16:16     ` Miklos Szeredi
2020-02-04 17:02       ` Amir Goldstein
2020-02-04 18:42         ` Vivek Goyal
2020-02-04 19:11           ` Amir Goldstein
2020-02-04 19:16             ` Miklos Szeredi
2020-02-20  7:52         ` Amir Goldstein
2020-02-20 20:00           ` Amir Goldstein
2020-03-14 13:16             ` Amir Goldstein
2020-03-16 17:54               ` Vivek Goyal
2020-03-16 19:02                 ` Amir Goldstein [this message]
2020-03-16 19:40                   ` Vivek Goyal
2020-03-18 13:36                   ` unionmount testsuite with upper virtiofs Amir Goldstein
2020-03-19 21:40                     ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxgfTJwE2O1GGt-TY+6ijjKE13+ATTarijFGLiM69jk8HA@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mszeredi@redhat.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

($INBOX_DIR/description missing)

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-unionfs/0 linux-unionfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-unionfs linux-unionfs/ https://lore.kernel.org/linux-unionfs \
		linux-unionfs@vger.kernel.org
	public-inbox-index linux-unionfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-unionfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git