linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Murphy Zhou <jencce.kernel@gmail.com>
Cc: Chengguang Xu <cgxu519@mykernel.net>,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH] overlay/073: test with nfs_export being off
Date: Thu, 10 Sep 2020 16:59:50 +0300	[thread overview]
Message-ID: <CAOQ4uxh+ppPMOSeAZU3sdwxwb_ixMHEpHLF9ZO_MTiedNJRgsw@mail.gmail.com> (raw)
In-Reply-To: <20200910055110.3lumztku3ld4vf2j@xzhoux.usersys.redhat.com>

On Thu, Sep 10, 2020 at 8:51 AM Murphy Zhou <jencce.kernel@gmail.com> wrote:
>
> When nfs_export is enabled, the link count of upper dir
> objects are more then the expected number in this testcase.
> Because extra index entries are linked to upper inodes.
>
>  QA output created by 073
> +Expected link count is 12 but real count is 23, file name is dir
> +Expected link count is 12 but real count is 23, file name is 1
> ...
> +Expected link count is 12 but real count is 23, file name is 10
>  Silence is golden
>
> Signed-off-by: Murphy Zhou <jencce.kernel@gmail.com>
> ---
> Hi folks,
>
> Please help review that with nfs_export enabled, this is expected.
> I think so but I'm not 100% sure about it. Maybe it's a bug in
> the kernel.
>

Indeed this is expected.
With nfs_export, for every unlinked lower file/dir there is a whiteout
"tombstone" in the index directory, whose name is the file handle
of the unlinked inode.

So this test creates extra 11 tombstones with nfs_export enabled.

> Thanks.
>
>  tests/overlay/073 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/overlay/073 b/tests/overlay/073
> index 37860c92..b78551eb 100755
> --- a/tests/overlay/073
> +++ b/tests/overlay/073
> @@ -99,7 +99,7 @@ run_test_case()
>  {
>         _scratch_mkfs
>         make_lower_files ${1}
> -       _scratch_mount -o "index=on"
> +       _scratch_mount -o "index=on,nfs_export=off"

So the fix looks fine, but let's document why nfs_export=off is needed.

Thanks,
Amir.

  reply	other threads:[~2020-09-10 14:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-10  5:51 [PATCH] overlay/073: test with nfs_export being off Murphy Zhou
2020-09-10 13:59 ` Amir Goldstein [this message]
2020-09-11  2:18   ` [PATCH v2] " Murphy Zhou
2020-09-11  2:27     ` Amir Goldstein
2020-10-20  2:52     ` Murphy Zhou
2020-10-20  5:22       ` Eryu Guan
2020-10-23  0:31         ` Murphy Zhou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxh+ppPMOSeAZU3sdwxwb_ixMHEpHLF9ZO_MTiedNJRgsw@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=cgxu519@mykernel.net \
    --cc=fstests@vger.kernel.org \
    --cc=jencce.kernel@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).