linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: Kevin Locke <kevin@kevinlocke.name>,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: add xino to "changes to underlying fs" docs
Date: Tue, 9 Mar 2021 21:24:09 +0200	[thread overview]
Message-ID: <CAOQ4uxhHKd9PMb5-6_nZ+RNDB8LrEabSJaVAPR6xkFtzChF+Sw@mail.gmail.com> (raw)
In-Reply-To: <20210309185032.GI77194@redhat.com>

> > I just mislead you. Sorry for that.
> > We should leave "redirect_dir" in the documented list and add "xino"
> > just like the patch you posted.
> > But I guess if I am going to post a patch to change the xino behavior,
> > it would be better to include your change in my patch for context.
>
> This is quite complex to understand. I think I still stick to general
> stand that if any overlay feature stores any metadata info about
> lower layer in upper layer, then we should not allow changes to
> offline layers.  Otherwise there are so many possibilities to analyze
> to figure out the effect of a offline change. It is confusing for
> developers as well as users. So, IMHO, I will take simpler approach of
> no lower layer modifications for all these advanced features otherwise
> expect the unexpected. :-)
>

Eventually, I only added "xino" to the list, the same as Kevin's patch,
but I also changed the code and documentation of the "xino" feature.

Thanks,
Amir.

      reply	other threads:[~2021-03-09 19:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAOQ4uxj4zNHU49Q6JeUrw4dvgRBumzhtvGXpuG4WDEi5G7uyxw@mail.gmail.com>
2021-03-08 15:23 ` [PATCH] ovl: add xino to "changes to underlying fs" docs Kevin Locke
2021-03-08 17:41   ` Amir Goldstein
2021-03-08 23:49     ` Kevin Locke
2021-03-09  7:24       ` Amir Goldstein
2021-03-09 14:29         ` Amir Goldstein
2021-03-09 17:43         ` Kevin Locke
2021-03-09 18:50         ` Vivek Goyal
2021-03-09 19:24           ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxhHKd9PMb5-6_nZ+RNDB8LrEabSJaVAPR6xkFtzChF+Sw@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=kevin@kevinlocke.name \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).