linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: "Yurkov, Vyacheslav" <Vyacheslav.Yurkov@bruker.com>
Cc: Vyacheslav Yurkov <uvv.mail@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] ovl: do not set overlay.opaque for new directories
Date: Tue, 1 Jun 2021 11:33:21 +0300	[thread overview]
Message-ID: <CAOQ4uxhN6t1fke1XxRndb9UN1M2sY9LVL9zKW_xj9xsXUrhr-Q@mail.gmail.com> (raw)
In-Reply-To: <AM8PR10MB4161DB3BDC0D415D5D3D5154863E9@AM8PR10MB4161.EURPRD10.PROD.OUTLOOK.COM>

On Tue, Jun 1, 2021 at 9:54 AM Yurkov, Vyacheslav
<Vyacheslav.Yurkov@bruker.com> wrote:
>
> Hi Amir,
> Thanks again for the review and a heads-up about the tests. I was not aware they exist.
>
> It took me some time to set them up due to really peculiar Makefile, but I now even have a yocto recipe to build them (will file it upstream later).
>
> The latest master and my v3 both report the same results:
> Failures: overlay/005 overlay/065 overlay/075
> Failed 3 of 93 tests
> (The full log is attached)
>
> I assume the failures come due to my specific configuration, but since master and v3 issue the same results I should be fine here.

Maybe.
Failure of overlay/075 on master is known.
Failure of overlay/065 on master was fixed by xfstests commit
* 6159ae7f - overlay/065: Adapt test to relaxed rules
so you may want to update your xfstests copy.

Failure of overlay/005 is not familiar to me and the
attached log is missing all the output of the test -
it just has the summary.

Worst yet, according to summary, all those test do not run in your setup:
Not run: overlay/001 overlay/004 overlay/008 overlay/015 overlay/020
overlay/021 overlay/025 overlay/032 overlay/045 overlay/046
overlay/056 overlay/064 overlay/100 overlay/101 overlay/102
overlay/103 overlay/104 overlay/105 overlay/106 overlay/107
overlay/108 overlay/109 overlay/110 overlay/111 overlay/112
overlay/113 overlay/114 overlay/115 overlay/116 overlay/117

Can you provide the full log to understand the reason or figure it out yourself
and fix this.
If you are running a special setup that is fine, it doesn't have to
run all the test
(as long as you know why), but in order to verify that your patches did not
break other setups, you need to test with a common setup where all the
above tests run and pass, short of overlay/075 which is a known upstream issue.


>
> v2 indeed caused a few more failures on top of that:
> Failures: overlay/005 overlay/065 overlay/070 overlay/071 overlay/075
> Failed 5 of 93 tests
>

I'm a bit surprised that tests overlay/068 overlay/069 did not fail with v2
Maybe they did not run and you did not notice that in the report?

> Could you please tell me just for my information what's the usual time frame to have my v3 mainlined?
>

Miklos would have to answer this question.
It shouldn't take long if he agrees with the patch.

Thanks,
Amir.

  reply	other threads:[~2021-06-01  8:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-27 17:45 [PATCH v3 1/3] ovl: disable decoding null uuid with redirect dir Vyacheslav Yurkov
2021-05-27 17:45 ` [PATCH v3 2/3] ovl: add ovl_allow_offline_changes() helper Vyacheslav Yurkov
2021-05-27 17:45 ` [PATCH v3 3/3] ovl: do not set overlay.opaque for new directories Vyacheslav Yurkov
2021-05-28 11:38   ` Amir Goldstein
2021-06-01  6:53     ` Yurkov, Vyacheslav
2021-06-01  8:33       ` Amir Goldstein [this message]
2021-06-01 16:29         ` Yurkov, Vyacheslav
2021-06-01 18:29           ` Amir Goldstein
2021-06-04 12:32             ` Amir Goldstein
2021-06-04 14:50               ` Yurkov, Vyacheslav
2021-06-04 19:18                 ` Amir Goldstein
2021-07-19 14:29   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOQ4uxhN6t1fke1XxRndb9UN1M2sY9LVL9zKW_xj9xsXUrhr-Q@mail.gmail.com \
    --to=amir73il@gmail.com \
    --cc=Vyacheslav.Yurkov@bruker.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=uvv.mail@gmail.com \
    --subject='Re: [PATCH v3 3/3] ovl: do not set overlay.opaque for new directories' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).