From: Amir Goldstein <amir73il@gmail.com>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: (RESEND) [PATCH] ovl: stacked file operation for mmap
Date: Sun, 18 Oct 2020 10:53:23 +0300 [thread overview]
Message-ID: <CAOQ4uxha5-88Rzi9D_zy4aDG76qthfQgo3LrR=DmJYgM-vfbEQ@mail.gmail.com> (raw)
In-Reply-To: <20201016155745.2876-1-cgxu519@mykernel.net>
On Fri, Oct 16, 2020 at 7:38 PM Chengguang Xu <cgxu519@mykernel.net> wrote:
>
> Currently only mmap does not behave as stacked file operation,
> although in practice there is less change to open a file in
> RDONLY mode and take long time to do mmap but the fix looks
> reasonable.
I suppose you do not have a real life use case where this fix
is relevant?
The thing is that this change is not without consequence.
It could result in 2 overlapping mmaps on the same RDONLY fd
mapping a different file and it can be even more confusing
than different fd mapping different files.
It is not clear which non-standard behavior is preferred, so without
any evidence that one strange behavior is preferred over the other
I don't think we should change anything.
Thanks,
Amir.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
> ---
> Hi Miklos,
>
> I'm sorry that I did a mistake about signed-off-by tag in previous
> email, so I resend this patch.
>
> fs/overlayfs/file.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c
> index 3582c3ae819c..f98b1c0c975b 100644
> --- a/fs/overlayfs/file.c
> +++ b/fs/overlayfs/file.c
> @@ -461,6 +461,7 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
> {
> struct file *realfile = file->private_data;
> const struct cred *old_cred;
> + struct fd real;
> int ret;
>
> if (!realfile->f_op->mmap)
> @@ -469,7 +470,11 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
> if (WARN_ON(file != vma->vm_file))
> return -EIO;
>
> - vma->vm_file = get_file(realfile);
> + ret = ovl_real_fdget(file, &real);
> + if (ret)
> + return ret;
> +
> + vma->vm_file = get_file(real.file);
>
> old_cred = ovl_override_creds(file_inode(file)->i_sb);
> ret = call_mmap(vma->vm_file, vma);
> @@ -477,13 +482,14 @@ static int ovl_mmap(struct file *file, struct vm_area_struct *vma)
>
> if (ret) {
> /* Drop reference count from new vm_file value */
> - fput(realfile);
> + fput(real.file);
> } else {
> /* Drop reference count from previous vm_file value */
> fput(file);
> }
>
> ovl_file_accessed(file);
> + fdput(real);
>
> return ret;
> }
> --
> 2.26.2
>
>
next prev parent reply other threads:[~2020-10-18 7:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 15:57 (RESEND) [PATCH] ovl: stacked file operation for mmap Chengguang Xu
2020-10-18 7:53 ` Amir Goldstein [this message]
2020-10-19 6:23 ` Chengguang Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOQ4uxha5-88Rzi9D_zy4aDG76qthfQgo3LrR=DmJYgM-vfbEQ@mail.gmail.com' \
--to=amir73il@gmail.com \
--cc=cgxu519@mykernel.net \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).