($INBOX_DIR/description missing)
 help / color / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <guan@eryu.me>
Cc: Eryu Guan <guaneryu@gmail.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	Vivek Goyal <vgoyal@redhat.com>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH 0/3] Running unionmount testsuite from xfstests
Date: Sun, 26 Jul 2020 19:21:53 +0300
Message-ID: <CAOQ4uxhfxay_K9R12dY1gGTRw_su5m77YtX3nKXKmph4Vi=g0w@mail.gmail.com> (raw)
In-Reply-To: <20200726151632.GJ2557159@desktop>

> >
> > > The test itself looks really good to me, my only concern is that
> > > the updates in unionmount repo are not visible to fstests, and may cause
> > > new failures, which are out of fstests' control. But I'm not sure if
> > > this really is a problem for people.
> > >
> > > I came up with two options anyway
> > > - add unionmount tests as a submodule of fstests
> > > - put unionmount tests in fstests
> > >
> >
> > I suppose you mean git submodule?
>
> Exactly.
>
> But I think I'd merge it as-is, git submodule brings more maintain
> burden on both maintainers and users, especially users that usually
> don't care about overlay tests. Users that care about overlay tests
> should setup unionmount tests explicitly and know that's unionmount
> tests if there's any test failure.
>

Great!

I see you also kept my 100+N test numbering, which is very convenient :-)

I have a patch on my dev branch to run unionmount test cases with
metacopy enabled that Vivek requested.

Will post it this week.

Thanks!
Amir.

      reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-31 11:01 Amir Goldstein
2020-05-31 11:01 ` [PATCH 1/3] overlay: run unionmount testsuite test cases Amir Goldstein
2020-05-31 11:01 ` [PATCH 2/3] overlay: add unionmount tests with multi lower layers Amir Goldstein
2020-05-31 11:01 ` [PATCH 3/3] overlay: add unionmount tests with nested overlay Amir Goldstein
2020-06-01 17:52 ` [PATCH 0/3] Running unionmount testsuite from xfstests Vivek Goyal
2020-06-01 19:18   ` Amir Goldstein
2020-07-19 18:11 ` Eryu Guan
2020-07-19 18:36   ` Amir Goldstein
2020-07-26 15:16     ` Eryu Guan
2020-07-26 16:21       ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxhfxay_K9R12dY1gGTRw_su5m77YtX3nKXKmph4Vi=g0w@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=fstests@vger.kernel.org \
    --cc=guan@eryu.me \
    --cc=guaneryu@gmail.com \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

($INBOX_DIR/description missing)

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-unionfs/0 linux-unionfs/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-unionfs linux-unionfs/ https://lore.kernel.org/linux-unionfs \
		linux-unionfs@vger.kernel.org
	public-inbox-index linux-unionfs

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-unionfs


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git