linux-unionfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@linux.alibaba.com>
Cc: Eryu Guan <guaneryu@gmail.com>, Icenowy Zheng <icenowy@aosc.io>,
	Chengguang Xu <cgxu519@mykernel.net>,
	Xiao Yang <yangx.jy@cn.fujitsu.com>,
	Miklos Szeredi <miklos@szeredi.hu>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	fstests <fstests@vger.kernel.org>
Subject: Re: [PATCH 4/4] overlay: Test lost immutable/append-only flags on copy-up
Date: Thu, 28 Jan 2021 08:45:34 +0200	[thread overview]
Message-ID: <CAOQ4uxi1wpoeWXnkf6BJjttt=c2cd1cuckvfO6G3xMHUb4w_OA@mail.gmail.com> (raw)
In-Reply-To: <20210127025752.GG58500@e18g06458.et15sqa>

On Wed, Jan 27, 2021 at 4:58 AM Eryu Guan <eguan@linux.alibaba.com> wrote:
>
> On Mon, Jan 25, 2021 at 03:24:07PM +0200, Amir Goldstein wrote:
> > On Sat, Jan 16, 2021 at 6:56 PM Amir Goldstein <amir73il@gmail.com> wrote:
> > >
> > > Chengguang Xu reported [1] that append-only flag is lost on copy-up.
> > > I had noticed that for directories, immutable flag can also be lost on
> > > copy up (when parent is copied up). That's an old overlayfs bug.
> > >
> > > Overlayfs added the ability to set inode flags (e.g. chattr +i) in
> > > kernel 5.10 by commit 61536bed2149 ("ovl: support [S|G]ETFLAGS and
> > > FS[S|G]ETXATTR ioctls for directories").
> > > Icenowy Zheng reported [2] a regression in that commit that causes
> > > a deadlock when setting inode flags on lower dir.
> > >
> > > There is a commented line in the test that triggers this deadlock,
> > > but it has been left commented out until a fix is merged upstream.
> > >
> >
> > Re-iterate in correct thread:
> >
> > The fix for above is in overlayfs-next:
> >
> > * 147ec02b8705 - ovl: avoid deadlock on directory ioctl
> >
> > But I wouldn't uncomment that line in the test just yet.
>
> Then I'd prefer wait for the deadlock fix land in upstream first, and
> merge the test with the deadlock trigger in place.
>
> Or as you mentioned in previous thread, we could seperate the deadlock
> case as a new test (also remove it from current overlay/075), so we
> could merge the [s,g]etxflags case first, then the deadlock case only
> when the fix is upstreamd.
>
> Either way works for me, I just want to avoid merging the test without
> the deadlock trigger, then uncomment it when the fix is available.
>

So let's wait for the deadlock fix to land and I will re-post with split
tests and address your minor comment.

Thanks,
Amir.

      reply	other threads:[~2021-01-28  6:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-16 16:56 [PATCH 0/4] Tests for overlayfs immutable/append-only files Amir Goldstein
2021-01-16 16:56 ` [PATCH 1/4] overlay/030: Update comment w.r.t upstream kernel Amir Goldstein
2021-01-16 16:56 ` [PATCH 2/4] src/t_immutable: factor out some helpers Amir Goldstein
2021-01-24 15:09   ` Eryu Guan
2021-01-24 15:29     ` Amir Goldstein
2021-01-25 12:35       ` Eryu Guan
2021-01-16 16:56 ` [PATCH 3/4] src/t_immutable: Allow setting flags on existing files Amir Goldstein
2021-01-24 15:14   ` Eryu Guan
2021-01-24 15:32     ` Amir Goldstein
2021-01-25 12:46       ` Eryu Guan
2021-01-25 13:17         ` Amir Goldstein
2021-01-16 16:56 ` [PATCH 4/4] overlay: Test lost immutable/append-only flags on copy-up Amir Goldstein
2021-01-25 13:24   ` Amir Goldstein
2021-01-26  8:47     ` Miklos Szeredi
2021-01-27  2:57     ` Eryu Guan
2021-01-28  6:45       ` Amir Goldstein [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAOQ4uxi1wpoeWXnkf6BJjttt=c2cd1cuckvfO6G3xMHUb4w_OA@mail.gmail.com' \
    --to=amir73il@gmail.com \
    --cc=cgxu519@mykernel.net \
    --cc=eguan@linux.alibaba.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=icenowy@aosc.io \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=yangx.jy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).