From: Amir Goldstein <amir73il@gmail.com>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: Miklos Szeredi <miklos@szeredi.hu>,
overlayfs <linux-unionfs@vger.kernel.org>
Subject: Re: [PATCH] ovl: fix incorrect extent info in metacopy case
Date: Wed, 24 Jun 2020 15:53:28 +0300 [thread overview]
Message-ID: <CAOQ4uxi53CzBwXxygKMhDDSaGpX0CcfV6jiaKRFVbrFHW7PbxA@mail.gmail.com> (raw)
In-Reply-To: <20200624102011.4861-1-cgxu519@mykernel.net>
On Wed, Jun 24, 2020 at 1:23 PM Chengguang Xu <cgxu519@mykernel.net> wrote:
>
> In metacopy case, we should use ovl_inode_realdata() instead of
> ovl_inode_real() to get real inode which has data, so that
> we can get correct information of extentes in ->fiemap operation.
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
looks right
Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> ---
> fs/overlayfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/inode.c b/fs/overlayfs/inode.c
> index 981f11ec51bc..a524af04b71d 100644
> --- a/fs/overlayfs/inode.c
> +++ b/fs/overlayfs/inode.c
> @@ -472,7 +472,7 @@ static int ovl_fiemap(struct inode *inode, struct fiemap_extent_info *fieinfo,
> u64 start, u64 len)
> {
> int err;
> - struct inode *realinode = ovl_inode_real(inode);
> + struct inode *realinode = ovl_inode_realdata(inode);
> const struct cred *old_cred;
>
> if (!realinode->i_op->fiemap)
> --
> 2.20.1
>
>
next prev parent reply other threads:[~2020-06-24 12:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 10:20 [PATCH] ovl: fix incorrect extent info in metacopy case Chengguang Xu
2020-06-24 12:53 ` Amir Goldstein [this message]
2020-06-25 8:35 ` Amir Goldstein
2020-06-25 9:46 ` cgxu
2020-08-14 9:23 ` cgxu
2020-10-30 10:16 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOQ4uxi53CzBwXxygKMhDDSaGpX0CcfV6jiaKRFVbrFHW7PbxA@mail.gmail.com \
--to=amir73il@gmail.com \
--cc=cgxu519@mykernel.net \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).