From: Amir Goldstein <amir73il@gmail.com> To: Miklos Szeredi <miklos@szeredi.hu> Cc: Eryu Guan <guaneryu@gmail.com>, Jeff Layton <jlayton@poochiereds.net>, overlayfs <linux-unionfs@vger.kernel.org>, fstests <fstests@vger.kernel.org> Subject: Re: [PATCH v2 4/5] overlay: test constant ino with nested overlay over samefs lower Date: Mon, 16 Mar 2020 15:52:33 +0200 Message-ID: <CAOQ4uxiANoiXhdbXMYLsttAHB9nrh_9vMn3z8usS46=H54QJ3A@mail.gmail.com> (raw) In-Reply-To: <CAJfpegvHAq+yT1qW4JqTBpviCHUrQqOPMfWEcvhy4Jpr2bLJfQ@mail.gmail.com> On Mon, Mar 16, 2020 at 2:29 PM Miklos Szeredi <miklos@szeredi.hu> wrote: > > On Mon, Dec 30, 2019 at 3:14 PM Amir Goldstein <amir73il@gmail.com> wrote: > > > > Also test that d_ino of readdir entries and i_ino from /proc/locks are > > consistent with st_ino and that inode numbers persist after rename to > > new parent, drop caches and mount cycle. > > overlay/070 and overlay/071 fail for me like this: > > QA output created by 071 > +flock: cannot open lock file > /scratch/ovl-mnt/lowertestdir/blkdev: No such device or address > ... > > I.e. there's no block dev with rdev=1/1. > > I don't see any other way to fix this, than to remove the device > tests. I ran into similar complain when I worked on generic/564. Apparently, this is not the first test that uses rdev b/1/1 and c/1/1 so not sure how those tests work for everyone. In generic/564 I used a loopdev as blockdev and /dev/zero as chardev. > Why are these needed? Is locking code in any way dependent on > file type? > Not strictly needed. See that they already skip file types fifo|socket|symlink. But note that we are not testing locking, we are using /proc/locks to get a peek at i_ino, so if we skip also blockdev and chardev, we end up testing no special files at all for i_ino consistency. Not the end of the world, but then again using loop dev and /dev/zero would be quite trivial as well. If it bothers you, I can post a fix. Thanks, Amir.
next prev parent reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-30 14:14 [PATCH v2 0/5] Nested overlay tests Amir Goldstein 2019-12-30 14:14 ` [PATCH v2 1/5] overlay: create the overlay/nested test group Amir Goldstein 2019-12-30 14:14 ` [PATCH v2 2/5] overlay: test file handles with nested overlay over samefs lower Amir Goldstein 2019-12-30 14:14 ` [PATCH v2 3/5] overlay: test file handles with nested overlay over non-samefs lower Amir Goldstein 2019-12-30 14:14 ` [PATCH v2 4/5] overlay: test constant ino with nested overlay over samefs lower Amir Goldstein 2020-03-16 12:28 ` Miklos Szeredi 2020-03-16 13:52 ` Amir Goldstein [this message] 2020-03-16 14:01 ` Miklos Szeredi 2019-12-30 14:14 ` [PATCH v2 5/5] overlay: test constant ino with nested overlay over non-samefs lower Amir Goldstein
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAOQ4uxiANoiXhdbXMYLsttAHB9nrh_9vMn3z8usS46=H54QJ3A@mail.gmail.com' \ --to=amir73il@gmail.com \ --cc=fstests@vger.kernel.org \ --cc=guaneryu@gmail.com \ --cc=jlayton@poochiereds.net \ --cc=linux-unionfs@vger.kernel.org \ --cc=miklos@szeredi.hu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
($INBOX_DIR/description missing) Archives are clonable: git clone --mirror https://lore.kernel.org/linux-unionfs/0 linux-unionfs/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-unionfs linux-unionfs/ https://lore.kernel.org/linux-unionfs \ linux-unionfs@vger.kernel.org public-inbox-index linux-unionfs Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-unionfs AGPL code for this site: git clone https://public-inbox.org/public-inbox.git