From: Brian Goff <cpuguy83@gmail.com>
To: Tycho Andersen <tycho@tycho.ws>,
James Bottomley <James.Bottomley@hansenpartnership.com>,
Miklos Szeredi <miklos@szeredi.hu>,
containers@lists.linux-foundation.org,
linux-unionfs@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Seth Forshee <seth.forshee@canonical.com>,
Eric Biederman <ebiederm@xmission.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] fs: introduce uid/gid shifting bind mount
Date: Fri, 17 Jan 2020 13:33:00 -0800 [thread overview]
Message-ID: <dejalu-217-910ea575-f51c-42ae-b89d-44387784c12f@gmail.com> (raw)
In-Reply-To: <20200117211940.GA22062@cisco>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
There are also cases where you’d want to bind-mount a host dir into a shifted container and have that be writeable, not just to an overlay.
—
On January 17, 2020 at 1:19 PM, Tycho Andersen wrote:
> Please, no. mount() failures are already hard to reason about, I would
> rather not add another temporary (or worse, permanent) non-obvious
> failure mode.
>
> What if we make shifted bind mounts always readonly? That will force
> people to use an overlay (or something else) on top, but they probably
> want to do that anyway so they can avoid tainting the original
> container image with writes.
>
> It's not just the cool factor: if you're doing this, it's presumably
> because you want to use it with a container in a user namespace.
> Specifying the same parameters twice leaves room for error, causing
> CVEs and more work.
>
> Tycho
> _______________________________________________
> Containers mailing list
> Containers@lists.linux-foundation.org (mailto:Containers@lists.linux-foundation.org)
> lists.linuxfoundation.org/mailman/listinfo/containers (https://lists.linuxfoundation.org/mailman/listinfo/containers)
>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1843 bytes --]
next prev parent reply other threads:[~2020-01-17 21:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 20:39 [PATCH v2 0/3] introduce a uid/gid shifting bind mount James Bottomley
2020-01-04 20:39 ` [PATCH v2 1/3] fs: rethread notify_change to take a path instead of a dentry James Bottomley
2020-01-04 21:52 ` Amir Goldstein
2020-01-04 20:39 ` [PATCH v2 2/3] fs: introduce uid/gid shifting bind mount James Bottomley
2020-01-04 23:09 ` Amir Goldstein
2020-01-05 17:44 ` James Bottomley
2020-01-13 3:41 ` Serge E. Hallyn
2020-01-15 18:19 ` James Bottomley
2020-01-16 6:44 ` Serge E. Hallyn
2020-01-16 16:29 ` James Bottomley
2020-01-17 15:44 ` Serge E. Hallyn
2020-01-17 16:25 ` James Bottomley
2020-01-17 21:19 ` Tycho Andersen
2020-01-17 21:33 ` Brian Goff [this message]
2020-01-17 22:52 ` James Bottomley
2020-01-04 20:39 ` [PATCH v2 3/3] fs: expose shifting bind mount to userspace James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dejalu-217-910ea575-f51c-42ae-b89d-44387784c12f@gmail.com \
--to=cpuguy83@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=containers@lists.linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=seth.forshee@canonical.com \
--cc=tycho@tycho.ws \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).