From: Oliver Neukum <oneukum@suse.com>
To: Johan Hovold <johan@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation
Date: Thu, 08 Apr 2021 13:34:12 +0200 [thread overview]
Message-ID: <0049152ce9da85c50fda91c1b77ca233ba0fef3d.camel@suse.com> (raw)
In-Reply-To: <YG7RiLoscS6VXG7n@hovoldconsulting.com>
Am Donnerstag, den 08.04.2021, 11:48 +0200 schrieb Johan Hovold:
> On Thu, Apr 08, 2021 at 10:36:46AM +0200, Oliver Neukum wrote:
> > Am Mittwoch, den 07.04.2021, 12:28 +0200 schrieb Johan Hovold:
> > Well, the devices report it. It is part of the standard.
>
> No, the standard doesn't include anything about a baud-base clock
> AFAICT.
Unfortunately it does.
dwDTERate - chapter 6.3.11 - table 17
If we does this wrongly, we should certainly fix it, but just removing
the reporting doesn't look right to me.
Regards
Oliver
next prev parent reply other threads:[~2021-04-08 11:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 10:28 [PATCH 0/3] USB: cdc-acm: TIOCSSERIAL fixes Johan Hovold
2021-04-07 10:28 ` [PATCH 1/3] Revert "USB: cdc-acm: fix rounding error in TIOCSSERIAL" Johan Hovold
2021-04-07 11:04 ` Anthony Mallet
2021-04-07 11:25 ` Johan Hovold
2021-04-07 10:28 ` [PATCH 2/3] USB: cdc-acm: fix unprivileged TIOCCSERIAL Johan Hovold
2021-04-08 7:48 ` Oliver Neukum
2021-04-08 9:42 ` Johan Hovold
2021-04-08 11:35 ` Oliver Neukum
2021-04-07 10:28 ` [PATCH 3/3] USB: cdc-acm: fix TIOCGSERIAL implementation Johan Hovold
2021-04-08 8:36 ` Oliver Neukum
2021-04-08 9:48 ` Johan Hovold
2021-04-08 11:34 ` Oliver Neukum [this message]
2021-04-08 11:54 ` Johan Hovold
2021-04-08 11:59 ` Oliver Neukum
2021-04-08 12:07 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0049152ce9da85c50fda91c1b77ca233ba0fef3d.camel@suse.com \
--to=oneukum@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).