From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Puma Hsu <pumahsu@google.com>
Cc: "Artem S . Tashkinov" <aros@gmx.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xhci: Don't show warning for reinit on known broken suspend
Date: Wed, 14 Sep 2022 15:28:09 +0300 [thread overview]
Message-ID: <02ef1ae2-9dae-6f02-9951-1230939f06e2@linux.intel.com> (raw)
In-Reply-To: <20220913203515.451-1-mario.limonciello@amd.com>
On 13.9.2022 23.35, Mario Limonciello wrote:
> commit 8b328f8002bc ("xhci: re-initialize the HC during resume if HCE was
> set") introduced a new warning message when the host controller error
> was set and re-initializing.
>
> This is expected behavior on some designs which already set
> `xhci->broken_suspend` so the new warning is alarming to some users.
>
> Modify the code to only show the warning if this was a surprising behavior
> to the XHCI driver.
>
> Fixes: 8b328f8002bc ("xhci: re-initialize the HC during resume if HCE was set")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216470
> Reported-by: Artem S. Tashkinov <aros@gmx.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
Thanks, adding to queue
-Mathias
prev parent reply other threads:[~2022-09-14 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 20:35 [PATCH] xhci: Don't show warning for reinit on known broken suspend Mario Limonciello
2022-09-14 12:28 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ef1ae2-9dae-6f02-9951-1230939f06e2@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=aros@gmx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mathias.nyman@intel.com \
--cc=pumahsu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).