From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>, Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH v2 8/9] usb: phy: tahvo: add IRQ check
Date: Fri, 13 Aug 2021 13:33:04 +0300 [thread overview]
Message-ID: <02f48143-6fc6-6af6-f070-748b4dbbcc6a@omp.ru> (raw)
In-Reply-To: <YRYY+0y3rZeRDLFA@kroah.com>
On 13.08.2021 10:02, Greg Kroah-Hartman wrote:
> On Mon, Aug 09, 2021 at 11:52:05PM +0300, Sergey Shtylyov wrote:
>> The driver neglects to check the result of platform_get_irq()'s call and
>> blithely passes the negative error codes to request_irq() (which takes
>> *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an original
>> error code. Stop calling request_irq() with the invalid IRQ #s.
>>
>> Fixes: 0807c500a1a6 ("USB: add Freescale USB OTG Transceiver driver")
>> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>>
>> ---
>> drivers/usb/phy/phy-fsl-usb.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> This patch did not apply to my tree :(
No wonder -- I managed to send the FSL PHY patch twice. Sorry about all
the mess! :-/
MBR, Sergei
next prev parent reply other threads:[~2021-08-13 10:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 20:16 [PATCH v2 0/9] Stop calling request_irq(), etc. with invalid IRQs in the USB drivers Sergey Shtylyov
2021-08-09 20:21 ` [PATCH v2 1/9] usb: dwc3: meson-g12a: add IRQ check Sergey Shtylyov
2021-08-09 20:23 ` [PATCH v2 2/9] usb: dwc3: qcom: " Sergey Shtylyov
2021-08-09 20:27 ` [PATCH v2 3/6] usb: gadget: udc: at91: " Sergey Shtylyov
2021-08-09 20:35 ` [PATCH v2 4/9] usb: gadget: udc: s3c2410: " Sergey Shtylyov
2021-08-10 6:53 ` Krzysztof Kozlowski
2021-08-12 5:40 ` Felipe Balbi
2021-08-09 20:41 ` [PATCH v2 5/9] usb: host: ohci-tmio: " Sergey Shtylyov
2021-08-09 20:54 ` Alan Stern
2021-08-09 20:45 ` [PATCH v2 6/9] usb: misc: brcmstb-usb-pinmap: " Sergey Shtylyov
2021-08-10 9:51 ` Florian Fainelli
2021-08-09 20:50 ` [PATCH v2 7/9] usb: phy: fsl-usb: " Sergey Shtylyov
2021-08-12 5:38 ` Felipe Balbi
2021-08-09 20:52 ` [PATCH v2 8/9] usb: phy: tahvo: " Sergey Shtylyov
2021-08-12 5:39 ` Felipe Balbi
2021-08-13 7:02 ` Greg Kroah-Hartman
2021-08-13 10:33 ` Sergey Shtylyov [this message]
2021-08-09 20:53 ` [PATCH v2 9/9] usb: phy: twl6030: add IRQ checks Sergey Shtylyov
2021-08-12 5:39 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02f48143-6fc6-6af6-f070-748b4dbbcc6a@omp.ru \
--to=s.shtylyov@omp.ru \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).