Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Michael Grzeschik <m.grzeschik@pengutronix.de>,
	lars@metafoo.de, alexandru.Ardelean@analog.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	balbi@kernel.org
Cc: gregkh@linuxfoundation.org, bigeasy@linutronix.de,
	m.olbrich@pengutronix.de, kernel@pengutronix.de
Subject: Re: [PATCH] usb: dwc3: gadget: don't dequeue requests on already disabled endpoints
Date: Fri, 27 Mar 2020 11:53:18 +0300
Message-ID: <035d6582-b513-2ebd-f755-325df52e6a10@cogentembedded.com> (raw)
In-Reply-To: <20200327084302.606-1-m.grzeschik@pengutronix.de>

Hello!

On 27.03.2020 11:43, Michael Grzeschik wrote:

> dwc3_gadget_ep_disable gets called before the last request gets
> dequeued.
> 
> In __dwc3_gadget_ep_disable all started, pending and cancelled
> lists for this endpoint will call dwc3_gadget_giveback in
> dwc3_remove_requests.
> 
> After that no list containing the afterwards dequed request,

    Dequeued.

> therefor it is not necessary to run the dequeue routine.

    Therefore?

> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
[...]

MBR, Sergei

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 14:45 [PATCH] usb: dwc3: gadget: Handle dequeuing of non queued URB gracefully Alexandru Ardelean
2019-11-12 14:41 ` Michael Olbrich
2020-01-16 11:12   ` Ardelean, Alexandru
2020-01-16 13:05     ` Felipe Balbi
2020-01-16 13:24 ` [PATCH][RESEND] " Alexandru Ardelean
2020-01-30 12:02   ` Felipe Balbi
2020-03-10 13:22     ` Ardelean, Alexandru
2020-03-10 13:45       ` Lars-Peter Clausen
2020-03-10 14:07         ` Lars-Peter Clausen
2020-03-27  8:43           ` [PATCH] usb: dwc3: gadget: don't dequeue requests on already disabled endpoints Michael Grzeschik
2020-03-27  8:53             ` Sergei Shtylyov [this message]
2020-03-27 11:15               ` Andy Shevchenko
2020-03-27  9:14             ` Lars-Peter Clausen
2020-03-27 10:43               ` Michael Grzeschik
2020-03-27 10:55                 ` Lars-Peter Clausen
2020-03-28  8:27             ` Felipe Balbi
2020-03-29 19:02               ` Michael Grzeschik
2020-03-30  7:18                 ` Felipe Balbi
2020-03-30  8:25                   ` Michael Grzeschik
2020-03-30 10:06                     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=035d6582-b513-2ebd-f755-325df52e6a10@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=alexandru.Ardelean@analog.com \
    --cc=balbi@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@pengutronix.de \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.grzeschik@pengutronix.de \
    --cc=m.olbrich@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git