From: Kishon Vijay Abraham I <kishon@ti.com>
To: youling257 <youling257@gmail.com>, <alexandre.torgue@st.com>
Cc: <yoshihiro.shimoda.uh@renesas.com>, <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] phy: core: Add consumer device link support
Date: Fri, 7 Feb 2020 10:46:47 +0530 [thread overview]
Message-ID: <0c4a37a9-0a2e-e698-f423-53060854ea05@ti.com> (raw)
In-Reply-To: <20200206133918.15012-1-youling257@gmail.com>
Hi,
On 06/02/20 7:09 PM, youling257 wrote:
> This patch cause "dwc3 dwc3.3.auto: failed to create device link to dwc3.3.auto.ulpi" problem.
> https://bugzilla.kernel.org/show_bug.cgi?id=206435
I'm suspecting there is some sort of reverse dependency with dwc3 ULPI.
Can you try the following diff?
diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c
index 2eb28cc2d2dc..397311dcb116 100644
--- a/drivers/phy/phy-core.c
+++ b/drivers/phy/phy-core.c
@@ -687,7 +687,7 @@ struct phy *phy_get(struct device *dev, const char
*string)
get_device(&phy->dev);
- link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
+ link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
if (!link) {
dev_err(dev, "failed to create device link to %s\n",
dev_name(phy->dev.parent));
@@ -802,7 +802,7 @@ struct phy *devm_of_phy_get(struct device *dev,
struct device_node *np,
return phy;
}
- link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
+ link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
if (!link) {
dev_err(dev, "failed to create device link to %s\n",
dev_name(phy->dev.parent));
@@ -851,7 +851,7 @@ struct phy *devm_of_phy_get_by_index(struct device
*dev, struct device_node *np,
*ptr = phy;
devres_add(dev, ptr);
- link = device_link_add(dev, &phy->dev, DL_FLAG_STATELESS);
+ link = device_link_add(dev, &phy->dev, DL_FLAG_SYNC_STATE_ONLY);
if (!link) {
dev_err(dev, "failed to create device link to %s\n",
dev_name(phy->dev.parent));
Thanks
Kishon
next prev parent reply other threads:[~2020-02-07 5:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 14:37 [PATCH] phy: core: Add consumer device link support Alexandre Torgue
2019-12-04 15:33 ` Alexandre Torgue
2019-12-04 17:19 ` Greg Kroah-Hartman
2020-01-07 11:51 ` Jon Hunter
2020-01-08 7:29 ` Kishon Vijay Abraham I
2020-01-08 8:37 ` Alexandre Torgue
2020-02-06 13:39 ` youling257
2020-02-07 5:16 ` Kishon Vijay Abraham I [this message]
2020-02-07 6:57 ` youling 257
2020-02-10 8:08 ` Kishon Vijay Abraham I
2020-02-10 11:30 ` Alexandre Torgue
2020-02-10 12:18 ` Kishon Vijay Abraham I
2020-02-11 6:17 ` Saravana Kannan
2020-02-14 18:46 ` Andy Shevchenko
2020-02-17 8:35 ` Alexandre Torgue
2020-02-17 8:40 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c4a37a9-0a2e-e698-f423-53060854ea05@ti.com \
--to=kishon@ti.com \
--cc=alexandre.torgue@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=youling257@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).