linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Peter Chen <peter.chen@nxp.com>, balbi@kernel.org, shawnguo@kernel.org
Cc: robh+dt@kernel.org, fabio.estevam@nxp.com, kernel@pengutronix.de,
	devicetree@vger.kernel.org, aisheng.dong@nxp.com,
	linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
	linux-usb@vger.kernel.org, chunfeng.yun@mediatek.com
Subject: Re: [PATCH v4 6/8] ARM: dts: imx7ulp: add imx7ulp USBOTG1 support
Date: Sat, 15 Jun 2019 12:03:47 +0300	[thread overview]
Message-ID: <0dbf01f9-7c5c-ce0b-4feb-378c9147f15a@cogentembedded.com> (raw)
In-Reply-To: <20190614093544.11730-7-peter.chen@nxp.com>

On 14.06.2019 12:35, Peter Chen wrote:

> Add imx7ulp USBOTG1 support.
> 
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>   arch/arm/boot/dts/imx7ulp.dtsi | 28 ++++++++++++++++++++++++++++
>   1 file changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi b/arch/arm/boot/dts/imx7ulp.dtsi
> index fca6e50f37c8..5115e47715c3 100644
> --- a/arch/arm/boot/dts/imx7ulp.dtsi
> +++ b/arch/arm/boot/dts/imx7ulp.dtsi
> @@ -30,6 +30,7 @@
>   		serial1 = &lpuart5;
>   		serial2 = &lpuart6;
>   		serial3 = &lpuart7;
> +		usbphy0 = &usbphy1;

    Is that really needed?

[...]
> @@ -133,6 +134,33 @@
[...]
> +		usbphy1: usbphy@0x40350000 {

    Name it "usb-phy@40350000" please.

> +			compatible = "fsl,imx7ulp-usbphy", "fsl,imx6ul-usbphy";
> +			reg = <0x40350000 0x1000>;
> +			interrupts = <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&pcc2 IMX7ULP_CLK_USB_PHY>;
> +			#phy-cells = <0>;
> +		};
> +
>   		usdhc0: mmc@40370000 {
>   			compatible = "fsl,imx7ulp-usdhc", "fsl,imx6sx-usdhc";
>   			reg = <0x40370000 0x10000>;
> 

MBR, Sergei

  reply	other threads:[~2019-06-15  9:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14  9:35 [PATCH v4 0/8] Add imx7ulp USBOTG1 support Peter Chen
2019-06-14  9:35 ` [PATCH v4 1/8] doc: dt-binding: mxs-usb-phy: add compatible for 7ulp Peter Chen
2019-06-14  9:35 ` [PATCH v4 2/8] usb: phy: phy-mxs-usb: add imx7ulp support Peter Chen
2019-06-14  9:35 ` [PATCH v4 3/8] doc: dt-binding: ci-hdrc-usb2: add compatible string for imx7ulp Peter Chen
2019-06-14  9:35 ` [PATCH v4 4/8] doc: dt-binding: usbmisc-imx: " Peter Chen
2019-06-14  9:35 ` [PATCH v4 5/8] usb: chipidea: imx: add imx7ulp support Peter Chen
2019-06-14  9:35 ` [PATCH v4 6/8] ARM: dts: imx7ulp: add imx7ulp USBOTG1 support Peter Chen
2019-06-15  9:03   ` Sergei Shtylyov [this message]
2019-06-17  1:13     ` Peter Chen
2019-06-17 16:05       ` Sergei Shtylyov
2019-06-14  9:35 ` [PATCH v4 7/8] ARM: dts: imx7ulp-evk: enable " Peter Chen
2019-06-14  9:35 ` [PATCH v4 8/8] usb: chipidea: imx: "fsl,usbphy" phandle is not mandatory now Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0dbf01f9-7c5c-ce0b-4feb-378c9147f15a@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=aisheng.dong@nxp.com \
    --cc=balbi@kernel.org \
    --cc=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).