linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dietmar Eggemann <deggeman@gmx.de>
To: Rui Miguel Silva <rui.silva@linaro.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sebastian Siewior <bigeasy@linutronix.de>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/9] usb: isp1760: move to regmap for register access
Date: Fri, 20 Aug 2021 15:30:28 +0200	[thread overview]
Message-ID: <11ed5458-4b88-ad72-4497-89ff9346a40b@gmx.de> (raw)
In-Reply-To: <20210513084717.2487366-3-rui.silva@linaro.org>

Hi Rui,

On 13/05/2021 10:47, Rui Miguel Silva wrote:
> Rework access to registers and memory to use regmap framework.
> No change in current feature or way of work is intended with this
> change.
>
> This will allow to reuse this driver with other IP of this family,
> for example isp1763, with little changes and effort.
>

1da9e1c06873 - usb: isp1760: move to regmap for register access

Starting from this patch, our Arm TC2 platform (multi_v7_defconfig,
vexpress-v2p-ca15_a7.dts) doesn't boot anymore.
We discovered this in our v5.14-rc1 based task scheduler test build.

With 1da9e1c06873^1 :

# lsusb
Bus 001 Device 001: ID 1d6b:0002 <-- NXP ISP1760 USB Host Controller
Bus 001 Device 002: ID 0471:3526
Bus 001 Device 003: ID 0781:5591

# dmesg | grep -i isp
[    4.014307] isp1760 1b000000.usb: bus width: 32, oc: digital
[    4.014442] isp1760 1b000000.usb: NXP ISP1760 USB Host Controller
[    4.014715] isp1760 1b000000.usb: new USB bus registered, assigned bus number 1
[    4.025076] isp1760 1b000000.usb: irq 32, io mem 0x1b000000
[    4.025288] isp1760 1b000000.usb: USB ISP 1761 HW rev. 1 started
[    4.055802] ISP1760 USB device initialised
[    4.257911] isp1760 1b000000.usb: port 1 high speed
[    4.325662] usb 1-1: new high-speed USB device number 2 using isp1760
[    4.475670] isp1760 1b000000.usb: port 1 high speed
[   14.320372] usb 1-1.2: new high-speed USB device number 3 using isp1760

With v5.14-rc1 :

there is no boot output at all, but I debugged it a little bit and the
system seems to hang here:

[    1.847494] [<c0cac46c>] (isp1760_udc_register) from [<c0ca668c>] (isp1760_register+0x5d0/0x5f0)
[    1.847527] [<c0ca668c>] (isp1760_register) from [<c0ca6b7c>] (isp1760_plat_probe+0x150/0x1b0)
[    1.847557] [<c0ca6b7c>] (isp1760_plat_probe) from [<c0a46ef0>] (platform_probe+0x5c/0xb8)
[    1.847589] [<c0a46ef0>] (platform_probe) from [<c0a44924>] (really_probe.part.0+0x9c/0x32c)
...

    isp1760_udc_register()->isp1760_udc_init()

        ....
        /* Reset the device controller. */
        isp1760_udc_set(udc, DC_SFRESET); <-- hangs here !!!
        usleep_range(10000, 11000);
        isp1760_reg_write(udc->regs, ISP176x_DC_MODE, 0);
        usleep_range(10000, 11000);

[...]

  reply	other threads:[~2021-08-20 13:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13  8:47 [PATCH v4 0/9] usb: isp1760: extend support for isp1763 Rui Miguel Silva
2021-05-13  8:47 ` [PATCH v4 1/9] usb: isp1760: fix strict typechecking Rui Miguel Silva
2021-05-13  8:47 ` [PATCH v4 2/9] usb: isp1760: move to regmap for register access Rui Miguel Silva
2021-08-20 13:30   ` Dietmar Eggemann [this message]
2021-08-20 14:36     ` Rui Miguel Silva
2021-05-13  8:47 ` [PATCH v4 3/9] usb: isp1760: use relaxed primitives Rui Miguel Silva
2021-05-13  8:47 ` [PATCH v4 4/9] usb: isp1760: remove platform data struct and code Rui Miguel Silva
2021-05-13  8:47 ` [PATCH v4 5/9] usb: isp1760: hcd: refactor mempool config and setup Rui Miguel Silva
2021-05-13  8:47 ` [PATCH v4 6/9] usb: isp1760: use dr_mode binding Rui Miguel Silva
2021-05-13  8:47 ` [PATCH v4 7/9] usb: isp1760: add support for isp1763 Rui Miguel Silva
2021-05-13  8:47 ` [PATCH v4 8/9] dt-bindings: usb: nxp,isp1760: add bindings Rui Miguel Silva
2021-05-18  1:08   ` Rob Herring
2021-05-13  8:47 ` [PATCH v4 9/9] usb: isp1763: add peripheral mode Rui Miguel Silva
2021-06-06 22:52 ` [PATCH v4 0/9] usb: isp1760: extend support for isp1763 Laurent Pinchart
2021-06-07  8:42   ` Rui Miguel Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11ed5458-4b88-ad72-4497-89ff9346a40b@gmx.de \
    --to=deggeman@gmx.de \
    --cc=bigeasy@linutronix.de \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=rui.silva@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).