Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Aidan Thornton <makosoft@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>,
	Marco Zatta <marco@zatta.me>
Subject: Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.
Date: Tue, 02 Jul 2019 14:46:42 +0200
Message-ID: <1562071602.5819.14.camel@suse.com> (raw)
In-Reply-To: <CAB=c7ToV==vGZWOXaRqRcoOb4TNeVqi4QNAvgtiN0K6JjoF8Tg@mail.gmail.com>

Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton:

> This doesn't make much sense though. e387ef5c47dd should apply this
> quirk to all Logitech UVC webcams, and this is definitely a UVC-based
> Logitech webcam with the appropriate VID and interface descriptor.
> Surely it shouldn't make any difference whether I add an entry for the
> specific VID+PID pair of my particular camera or not? The C270 is as
> well, I think.

Well, it is applied a little later.

> What's particularly annoying is that since this is an intermittent
> problem, it's hard to tell if I'm chasing a phantom solution for it
> again. Haven't managed to replicate it since applying this fix and did
> so pretty quickly before but you never know.

Should I just readd everything removed in e387ef5c47dd?

Greg, what do you think? This is hard to test, the hardware is old
and I want to avoid chasing them all separately.

	Regards
		Oliver


  reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-01  7:52 Marco Zatta
2019-06-01  9:33 ` Sergei Shtylyov
2019-06-01 10:11   ` Marco Zatta
2019-06-01 11:45     ` Greg KH
2019-06-03  9:58 ` Oliver Neukum
2019-06-03 17:55   ` Marco Zatta
2019-06-04  9:14     ` Oliver Neukum
2019-06-05  9:30       ` Greg Kroah-Hartman
2019-06-20 20:19   ` Aidan Thornton
2019-07-02 12:46     ` Oliver Neukum [this message]
2019-07-02 13:25       ` Greg Kroah-Hartman
2019-07-03 13:54     ` Oliver Neukum

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1562071602.5819.14.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=makosoft@gmail.com \
    --cc=marco@zatta.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org linux-usb@archiver.kernel.org
	public-inbox-index linux-usb


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/ public-inbox