From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33A80C06510 for ; Tue, 2 Jul 2019 13:00:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 11730208C4 for ; Tue, 2 Jul 2019 13:00:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726457AbfGBNAf (ORCPT ); Tue, 2 Jul 2019 09:00:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:42440 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726167AbfGBNAf (ORCPT ); Tue, 2 Jul 2019 09:00:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 341D6B9C6; Tue, 2 Jul 2019 13:00:34 +0000 (UTC) Message-ID: <1562071602.5819.14.camel@suse.com> Subject: Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio. From: Oliver Neukum To: Aidan Thornton Cc: Greg Kroah-Hartman , Linux USB Mailing List , Marco Zatta Date: Tue, 02 Jul 2019 14:46:42 +0200 In-Reply-To: References: <20190601075257.GA24550@jimmy.localdomain> <1559555890.25071.5.camel@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Am Donnerstag, den 20.06.2019, 21:19 +0100 schrieb Aidan Thornton: > This doesn't make much sense though. e387ef5c47dd should apply this > quirk to all Logitech UVC webcams, and this is definitely a UVC-based > Logitech webcam with the appropriate VID and interface descriptor. > Surely it shouldn't make any difference whether I add an entry for the > specific VID+PID pair of my particular camera or not? The C270 is as > well, I think. Well, it is applied a little later. > What's particularly annoying is that since this is an intermittent > problem, it's hard to tell if I'm chasing a phantom solution for it > again. Haven't managed to replicate it since applying this fix and did > so pretty quickly before but you never know. Should I just readd everything removed in e387ef5c47dd? Greg, what do you think? This is hard to test, the hardware is old and I want to avoid chasing them all separately. Regards Oliver