From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A55C32753 for ; Wed, 14 Aug 2019 13:25:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1282206C1 for ; Wed, 14 Aug 2019 13:25:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728028AbfHNNZX (ORCPT ); Wed, 14 Aug 2019 09:25:23 -0400 Received: from mx2.suse.de ([195.135.220.15]:44380 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728116AbfHNNZW (ORCPT ); Wed, 14 Aug 2019 09:25:22 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 056F5B030; Wed, 14 Aug 2019 13:25:20 +0000 (UTC) Message-ID: <1565789116.5780.1.camel@suse.com> Subject: Re: divide error in usbtmc_generic_read From: Oliver Neukum To: syzbot , andreyknvl@google.com, syzkaller-bugs@googlegroups.com, steve_bayless@keysight.com, gregkh@linuxfoundation.org, guido.kiener@rohde-schwarz.com, linux-usb@vger.kernel.org Date: Wed, 14 Aug 2019 15:25:16 +0200 In-Reply-To: <000000000000c4157e0590123002@google.com> References: <000000000000c4157e0590123002@google.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Am Mittwoch, den 14.08.2019, 04:38 -0700 schrieb syzbot: > Hello, > > syzbot found the following crash on: > > HEAD commit: d0847550 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=16295d4a600000 > kernel config: https://syzkaller.appspot.com/x/.config?x=dbc9c80cc095da19 > dashboard link: https://syzkaller.appspot.com/bug?extid=55b0304b360654a7537b > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1288a31c600000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15282e86600000 > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+55b0304b360654a7537b@syzkaller.appspotmail.com #syz test: https://github.com/google/kasan.git d0847550 >From 5fa900e86e57d92a0b23a1a60ff4f4f13e997a93 Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Wed, 14 Aug 2019 15:21:41 +0200 Subject: [PATCH] usbtmc: more sanity checking for packet size A malicious device can make the driver divide ny zero with a nonsense maximum packet size. SIgned-off-by: Oliver Neukum --- drivers/usb/class/usbtmc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c index 4942122b2346..11042ca56818 100644 --- a/drivers/usb/class/usbtmc.c +++ b/drivers/usb/class/usbtmc.c @@ -2364,6 +2364,8 @@ static int usbtmc_probe(struct usb_interface *intf, data->bulk_in = bulk_in->bEndpointAddress; data->wMaxPacketSize = usb_endpoint_maxp(bulk_in); + if (!data->wMaxPacketSize) + goto err_put; dev_dbg(&intf->dev, "Found bulk in endpoint at %u\n", data->bulk_in); data->bulk_out = bulk_out->bEndpointAddress; -- 2.16.4