From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE54C433FF for ; Thu, 15 Aug 2019 10:42:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FB4F208C2 for ; Thu, 15 Aug 2019 10:42:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730255AbfHOKmG (ORCPT ); Thu, 15 Aug 2019 06:42:06 -0400 Received: from mx2.suse.de ([195.135.220.15]:51988 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726027AbfHOKmG (ORCPT ); Thu, 15 Aug 2019 06:42:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1EE1DADCB; Thu, 15 Aug 2019 10:42:03 +0000 (UTC) Message-ID: <1565865720.5780.3.camel@suse.com> Subject: Re: [PATCH] net: usbnet: fix a memory leak bug From: Oliver Neukum To: Wenwen Wang Cc: "David S. Miller" , open list , "open list:USB NETWORKING DRIVERS" , "open list:USB USBNET DRIVER FRAMEWORK" Date: Thu, 15 Aug 2019 12:42:00 +0200 In-Reply-To: <1565804493-7758-1-git-send-email-wenwen@cs.uga.edu> References: <1565804493-7758-1-git-send-email-wenwen@cs.uga.edu> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Am Mittwoch, den 14.08.2019, 12:41 -0500 schrieb Wenwen Wang: > In usbnet_start_xmit(), 'urb->sg' is allocated through kmalloc_array() by > invoking build_dma_sg(). Later on, if 'CONFIG_PM' is defined and the if > branch is taken, the execution will go to the label 'deferred'. However, > 'urb->sg' is not deallocated on this execution path, leading to a memory > leak bug. Just to make this clear: > Signed-off-by: Wenwen Wang NACK For the reason Jack explained. Deferral is not a failure. Regards Oliver