From: Oliver Neukum <oneukum@suse.com>
To: Charles.Hyde@dellteam.com, gregkh@linuxfoundation.org
Cc: Mario.Limonciello@dell.com, nic_swsd@realtek.com,
linux-acpi@vger.kernel.org, linux-usb@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [RFC 1/4] Add usb_get_address and usb_set_address support
Date: Thu, 22 Aug 2019 10:08:15 +0200 [thread overview]
Message-ID: <1566461295.8347.19.camel@suse.com> (raw)
In-Reply-To: <1566430506442.20925@Dellteam.com>
Am Mittwoch, den 21.08.2019, 23:35 +0000 schrieb
Charles.Hyde@dellteam.com:
> <snipped>
> >
> > This is a VERY cdc-net-specific function. It is not a "generic" USB
> > function at all. Why does it belong in the USB core? Shouldn't it live
> > in the code that handles the other cdc-net-specific logic?
> >
> > thanks,
> >
> > greg k-h
>
>
> Thank you for this feedback, Greg. I was not sure about adding this to message.c, because of the USB_CDC_GET_NET_ADDRESS. I had found references to SET_ADDRESS in the USB protocol at https://wiki.osdev.org/Universal_Serial_Bus#USB_Protocol. If one wanted a generic USB function for SET_ADDRESS, to be used for both sending a MAC address and receiving one, how would you suggest this be implemented? This is a legit question because I am curious.
Your implementation was, except for missing error handling, usable.
The problem is where you put it. CDC messages exist only for CDC
devices. Now it is true that there is no generic CDC driver.
Creating a module just for that would cost more memory than it saves
in most cases.
But MACs are confined to network devices. Hence the functionality
can be put into usbnet. It should not be put into any individual
driver, so that every network driver can use it without duplication.
> Your feedback led to moving the functionality into cdc_ncm.c for today's testing, and removing all changes from messages.c, usb.h, usbnet.c, and usbnet.h. This may be where I end up long term, but I would like to learn if there is a possible solution that could live in message.c and be callable from other USB-to-Ethernet aware drivers.
All those drivers use usbnet. Hence there it should be.
Regards
Oliver
next prev parent reply other threads:[~2019-08-22 8:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 22:18 [RFC 1/4] Add usb_get_address and usb_set_address support Charles.Hyde
2019-08-20 22:26 ` Greg KH
2019-08-21 23:35 ` Charles.Hyde
2019-08-22 8:08 ` Oliver Neukum [this message]
2019-08-22 17:14 ` Charles.Hyde
2019-08-20 22:28 ` Greg KH
2019-08-21 1:22 ` Andrew Lunn
2019-08-21 23:45 ` Charles.Hyde
2019-08-21 9:08 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566461295.8347.19.camel@suse.com \
--to=oneukum@suse.com \
--cc=Charles.Hyde@dellteam.com \
--cc=Mario.Limonciello@dell.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).