From: <Charles.Hyde@dellteam.com>
To: <linux-acpi@vger.kernel.org>
Cc: <Mario.Limonciello@dell.com>, <oliver@neukum.org>,
<nic_swsd@realtek.com>, <linux-usb@vger.kernel.org>
Subject: [RFC 0/3] Add support into cdc_ncm for MAC address pass through
Date: Fri, 23 Aug 2019 22:25:31 +0000 [thread overview]
Message-ID: <1566599131748.86079@Dellteam.com> (raw)
This is my second iteration of proposed code changes, based on feedback from the first iteration. I dropped my original changes to usb/core and usbnet, in favor of keeping the needed get/set ethernet address functions in cdc_ncm driver. The changes in cdc_ncm driver reflect similar code in at least one other driver, namely aqc111. Furthermore, the system used for testing is a chromebook that lacks iproute2, so I used ifconfig, debugging messages, and other chromebook tools to ensure these changes work as intended.
In recent testing of a Dell Universal Dock D6000, I found that MAC address pass through is not supported in the Linux drivers. However, this same device is supported in Windows 10 (Pro) on my personal computer, in as much as I was able to tell Windows to assign a new MAC address of my choosing, and I saw through wireshark the new MAC address was pushed out to the device. Afterward, Windows reported a new IP address and I was able to view web pages.
This series of patches give support to cdc_ncm USB based Ethernet controllers for programming a MAC address to the device, and also to retrieve the device's MAC address. This patch series further adds ACPI MAC address pass through support specifically for the cdc_ncm driver, and generally for any other driver that may need or want it, in furtherance of Dell's enterprise IT policy efforts. It was this latter that I initially found lacking when testing a D6000 with a Dell laptop, and then I found ifconfig was unable to set a MAC address into the device. These patches bring a similar level of functionality to cdc_ncm driver as is available with the Realtek r8152 driver, and is available with Windows.
Charles Hyde (3):
net: cdc_ncm: add get/set ethernet address functions
ACPI: move ACPI functionality out of r8152 driver
net: cdc_ncm: Add ACPI MAC address pass through functionality
drivers/net/usb/cdc_ncm.c | 121 ++++++++++++++++++++++++++++++-
drivers/net/usb/r8152.c | 44 +----------
include/acpi/acpi_mac_passthru.h | 16 ++++
lib/Makefile | 3 +-
lib/acpi_mac_passthru.c | 61 ++++++++++++++++
5 files changed, 200 insertions(+), 45 deletions(-)
create mode 100644 include/acpi/acpi_mac_passthru.h
create mode 100644 lib/acpi_mac_passthru.c
--
2.20.1
reply other threads:[~2019-08-23 22:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566599131748.86079@Dellteam.com \
--to=charles.hyde@dellteam.com \
--cc=Mario.Limonciello@dell.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).