linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Cercueil <paul@crapouillou.net>
To: Bin Liu <b-liu@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	od@zcrc.me, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Artur Rojek <contact@artur-rojek.eu>
Subject: Re: [PATCH v3 2/7] usb: musb: dma: Add support for shared IRQ
Date: Tue, 17 Dec 2019 22:04:38 +0100	[thread overview]
Message-ID: <1576616678.3.0@crapouillou.net> (raw)
In-Reply-To: <20191217144206.GM16429@iaqt7>

Hi Bin,


Le mar., déc. 17, 2019 at 08:42, Bin Liu <b-liu@ti.com> a écrit :
> Hi Paul,
> 
> On Wed, Dec 11, 2019 at 12:52:24PM -0600, Bin Liu wrote:
>>  On Tue, Dec 10, 2019 at 06:11:05PM +0100, Paul Cercueil wrote:
>>  > The implementation of the Inventra IP in some of the Ingenic 
>> JZ47xx SoCs
>>  > does not use a separate IRQ line for DMA transfers.
>>  >
>>  > Allow these SoCs to be supported by adding a flag 
>> 'dma_share_usb_irq'
>>  > in the struct musb. If set, no extra IRQ line is required, and 
>> the musb
>>  > glue will need to call the API function 
>> musbhs_dma_controller_irq()
>>  > within its interrupt handler.
>>  >
>>  > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
>>  > Tested-by: Artur Rojek <contact@artur-rojek.eu>
>>  > ---
>> 
>>  Queued for usb-next. Thanks.
> 
> I removed this and the next patch [3/7] in this series from my queue.
> Sorry. Ming Guo has posted a series "Add MediaTek MUSB Controller
> Driver" which has done the similar implementation [1] but without 
> adding
> the flag in struct musb. Can you please check if you can use Ming's
> implementation instead? The patch of his musb glue driver which uses 
> the
> implementation is [2], just for your reference.

Sure. Were these patches merged? What tree do they apply to? They don't 
apply cleanly on -rc2.

-Paul


> 
> [1] https://marc.info/?l=linux-usb&m=157602930627195&w=2
> [2] https://marc.info/?l=linux-usb&m=157602932427210&w=2
> 
> Thanks,
> -Bin.



  reply	other threads:[~2019-12-17 21:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 17:11 [PATCH v3 1/7] usb: musb: dma: Correct parameter passed to IRQ handler Paul Cercueil
2019-12-10 17:11 ` [PATCH v3 2/7] usb: musb: dma: Add support for shared IRQ Paul Cercueil
2019-12-11 18:52   ` Bin Liu
2019-12-17 14:42     ` Bin Liu
2019-12-17 21:04       ` Paul Cercueil [this message]
2019-12-17 21:17         ` Bin Liu
2019-12-10 17:11 ` [PATCH v3 3/7] usb: musb: jz4740: Add support for DMA Paul Cercueil
2019-12-11 18:52   ` Bin Liu
2019-12-10 17:11 ` [PATCH v3 4/7] usb: musb: jz4740: Drop dependency on NOP_USB_XCEIV Paul Cercueil
2019-12-11 18:53   ` Bin Liu
2019-12-10 17:11 ` [PATCH v3 5/7] usb: musb: jz4740: Silence error if code is -EPROBE_DEFER Paul Cercueil
2019-12-11 19:00   ` Bin Liu
2019-12-10 17:11 ` [PATCH v3 6/7] usb: musb: jz4740: Code cleanup Paul Cercueil
2019-12-10 19:59   ` Bin Liu
2019-12-14 11:30   ` Greg Kroah-Hartman
2019-12-10 17:11 ` [PATCH v3 7/7] usb: musb: jz4740: Disable pullup at init Paul Cercueil
2019-12-10 19:52   ` Bin Liu
2019-12-11 18:51 ` [PATCH v3 1/7] usb: musb: dma: Correct parameter passed to IRQ handler Bin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1576616678.3.0@crapouillou.net \
    --to=paul@crapouillou.net \
    --cc=b-liu@ti.com \
    --cc=contact@artur-rojek.eu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=od@zcrc.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).