From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA248C4332B for ; Thu, 19 Mar 2020 01:08:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 827BE20768 for ; Thu, 19 Mar 2020 01:08:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MT0Y8soJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726933AbgCSBIy (ORCPT ); Wed, 18 Mar 2020 21:08:54 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:35150 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726866AbgCSBIy (ORCPT ); Wed, 18 Mar 2020 21:08:54 -0400 Received: by mail-pg1-f195.google.com with SMTP id 7so266430pgr.2 for ; Wed, 18 Mar 2020 18:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:content-transfer-encoding:in-reply-to:references :subject:from:cc:to:date:message-id:user-agent; bh=HOrVTVj94hEqYzP+BNYpSkqs29uiFE6WXOJ/uoI1nY0=; b=MT0Y8soJkEXXSdQVlOiuDB77ehUHT9j37xPgvUaPEAjUfLvnUxhWsASSZRDBU80+UE 4Yvm727E1zUBc7xZdiND5J9r7CGnI47FLMRXA/TzwP0VJmbe4GjX95BHgnmtZ5gbpDnq YVcYCFBwG76DaaWPMx5qXkx/DqtnKFixVSljU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:content-transfer-encoding :in-reply-to:references:subject:from:cc:to:date:message-id :user-agent; bh=HOrVTVj94hEqYzP+BNYpSkqs29uiFE6WXOJ/uoI1nY0=; b=cLZIsMgdUa17jlLgyxK0RNm0ap/YnOos7dQeLJXoBq8QbmZnsj7KgM1/GziQBsGHWq BheCKDgLfn6Wdc949rGb5Rs/7HaU8VtnPh+3SYZ8cXApYqHLpQmXuoIBmqGvL7zZDP0V 1qsGJJCcV2tyVBnlLVtoFoO23IXiM8cT1BiG9c1kYWTToCAAg9rq+LerPZtYnXbgrmed g4dwT3LxIdO1ysir7D3/4uUBguEmVOaP2Bc6s8kH24NwyBloGXrb4D8qasy54Teel9kp dL9UKRDWpSTA1u/2ALZWoAhT0cY4CVw96wLu5hUPWuJO6pFZvYbp/oan2XtHVfclCZ95 RTfQ== X-Gm-Message-State: ANhLgQ01d2WYYM+AGM5qErwc6GIwHQoAzhNzBVGUpLeXZjpmRYjRKUQH jxbI9UVJ3kkIsh8qWBlBsmVS2w== X-Google-Smtp-Source: ADFU+vuAWgIWajuJGpPlRJxuUxjrbJeZVY6ltZuXXUYT9Lo/14j2AaHjIDuHwCwpxd//vqXGygp/gA== X-Received: by 2002:aa7:8bd1:: with SMTP id s17mr1130786pfd.225.1584580133274; Wed, 18 Mar 2020 18:08:53 -0700 (PDT) Received: from chromium.org ([2620:15c:202:1:fa53:7765:582b:82b9]) by smtp.gmail.com with ESMTPSA id y15sm209863pfc.206.2020.03.18.18.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 18:08:52 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200311191501.8165-3-bryan.odonoghue@linaro.org> References: <20200311191501.8165-1-bryan.odonoghue@linaro.org> <20200311191501.8165-3-bryan.odonoghue@linaro.org> Subject: Re: [PATCH 2/7] dt-bindings: usb: dwc3: Add a gpio-usb-connector example From: Stephen Boyd Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@linaro.org, jackp@codeaurora.org, robh@kernel.org, Bryan O'Donoghue , Rob Herring , Mark Rutland , devicetree@vger.kernel.org To: Bryan O'Donoghue , balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Date: Wed, 18 Mar 2020 18:08:51 -0700 Message-ID: <158458013177.152100.17920784952083533825@swboyd.mtv.corp.google.com> User-Agent: alot/0.9 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Quoting Bryan O'Donoghue (2020-03-11 12:14:56) > A USB connector should be a child node of the USB controller > connector/usb-connector.txt. This patch adds an example of how to do this > to the dwc3 binding descriptions. I read that as a child of the USB interface controller, which is not the same as the USB controller. For example, we're talking about having the usb connector be a child of the EC on ChromeOS devices because that manages the connector >=20 > It is necessary to declare a connector as a child-node of a USB controller > for role-switching to work, so this example should be helpful to others > implementing that. Maybe it should be a virtual node at the root of the DT if it's GPIO controlled? And then the phy can be connected to the usb connector through the graph binding. >=20 > Cc: Greg Kroah-Hartman > Cc: Rob Herring > Cc: Mark Rutland > Cc: linux-usb@vger.kernel.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Acked-by: Felipe Balbi > Reviewed-by: Rob Herring > Tested-by: Bjorn Andersson > Signed-off-by: Bryan O'Donoghue > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentati= on/devicetree/bindings/usb/dwc3.txt > index 66780a47ad85..4e1e4afccee6 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -121,4 +121,12 @@ dwc3@4a030000 { > interrupts =3D <0 92 4> > usb-phy =3D <&usb2_phy>, <&usb3,phy>; Weird that there's a comma here ^ Not a problem with this patch, just noticing it while reading the diff. > snps,incr-burst-type-adjustment =3D <1>, <4>, <8>, <16>; > + > + usb_con: connector { > + compatible =3D "gpio-usb-b-connector"; > + id-gpios =3D <&tlmm 116 GPIO_ACTIVE_HIGH>; > + vbus-supply =3D <&usb3_vbus_reg>; > + pinctrl-names =3D "default"; > + pinctrl-0 =3D <&usb3_id_pin>, <&usb3_vbus_pin>; > + };