From: Oliver Neukum <oneukum@suse.com>
To: Kyungtae Kim <kt0755@gmail.com>, linux-usb@vger.kernel.org
Subject: Re: Fwd: BUG: KASAN: use-after-free in usb_hcd_unlink_urb+0x5f/0x170 drivers/usb/core/hcd.c
Date: Tue, 24 Mar 2020 11:45:53 +0100 [thread overview]
Message-ID: <1585046753.7151.18.camel@suse.com> (raw)
In-Reply-To: <CAEAjamtTnn+BZAshQ7=DQ7QdRHO83AbHeZP3xY1CpSzmbaHPDQ@mail.gmail.com>
Am Montag, den 23.03.2020, 02:18 -0400 schrieb Kyungtae Kim:
> We report a bug (in linux-5.5.11) found by FuzzUSB (a modified version
> of syzkaller)
Hi,
thank you for the report. Is this a reproducible bug?
> In function usb_hcd_unlink_urb (driver/usb/core/hcd.c:1607), it tries to
> read "urb->use_count". But it seems the instance "urb" was
> already freed (right after urb->dev at line 1597) by the function "urb_destroy"
> in a different thread, which caused memory access violation.
Yes.
> To solve, it may need to check if urb is valid before urb->use_count,
> to avoid such freed memory access.
Difficult to do as the URB itself would be invalid.
I am afraid there is a race in here:
if (test_bit(US_FLIDX_ABORTING, &us->dflags)) {
/* cancel the request, if it hasn't been cancelled already */
if (test_and_clear_bit(US_FLIDX_SG_ACTIVE, &us->dflags)) {
usb_stor_dbg(us, "-- cancelling sg request\n");
usb_sg_cancel(&us->current_sg);
}
}
/* wait for the completion of the transfer */
usb_sg_wait(&us->current_sg);
clear_bit(US_FLIDX_SG_ACTIVE, &us->dflags);
What keeps the request alive while usb_sg_wait() is running?
Regards
Oliver
>
next prev parent reply other threads:[~2020-03-24 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAEAjamtb2Kbn0He5O++=d_HCG1eQvLnGGbcVUOQ76+NfDiNybQ@mail.gmail.com>
2020-03-23 6:18 ` Fwd: BUG: KASAN: use-after-free in usb_hcd_unlink_urb+0x5f/0x170 drivers/usb/core/hcd.c Kyungtae Kim
2020-03-24 10:45 ` Oliver Neukum [this message]
2020-03-24 13:29 ` Alan Stern
2020-03-24 14:14 ` Alan Stern
2020-03-24 14:37 ` Kyungtae Kim
2020-03-26 14:49 ` Alan Stern
2020-03-28 14:11 ` Kyungtae Kim
2020-03-28 15:31 ` Alan Stern
2020-03-28 15:39 ` Kyungtae Kim
2020-03-28 20:18 ` [PATCH] USB: core: Fix free-while-in-use bug in the USB S-Glibrary Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585046753.7151.18.camel@suse.com \
--to=oneukum@suse.com \
--cc=kt0755@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).