From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Al Cooper <alcooperx@gmail.com>
Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com,
"Alan Stern" <stern@rowland.harvard.edu>,
bcm-kernel-feedback-list@broadcom.com,
devicetree@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
linux-usb@vger.kernel.org, "Mark Rutland" <mark.rutland@arm.com>,
"Mathias Nyman" <mathias.nyman@intel.com>,
"Rob Herring" <robh+dt@kernel.org>
Subject: Re: [PATCH v2 2/4] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's
Date: Mon, 30 Mar 2020 10:35:24 +0800 [thread overview]
Message-ID: <1585535724.28859.18.camel@mhfsdcap03> (raw)
In-Reply-To: <20200327204711.10614-3-alcooperx@gmail.com>
Hi,
On Fri, 2020-03-27 at 16:47 -0400, Al Cooper wrote:
> Add support for Broadcom STB SoC's to the xhci platform driver
>
> Signed-off-by: Al Cooper <alcooperx@gmail.com>
> ---
> drivers/usb/host/xhci-brcm.c | 16 ++++++++++++++++
> drivers/usb/host/xhci-brcm.h | 16 ++++++++++++++++
> drivers/usb/host/xhci-plat.c | 11 +++++++++++
> 3 files changed, 43 insertions(+)
> create mode 100644 drivers/usb/host/xhci-brcm.c
> create mode 100644 drivers/usb/host/xhci-brcm.h
>
> diff --git a/drivers/usb/host/xhci-brcm.c b/drivers/usb/host/xhci-brcm.c
> new file mode 100644
> index 000000000000..bf8c0bfd1780
> --- /dev/null
> +++ b/drivers/usb/host/xhci-brcm.c
> @@ -0,0 +1,16 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2018, Broadcom */
> +
> +#include <linux/usb.h>
> +#include <linux/usb/hcd.h>
> +
> +#include "xhci.h"
> +
> +int xhci_plat_brcm_init_quirk(struct usb_hcd *hcd)
> +{
> + struct xhci_hcd *xhci = hcd_to_xhci(hcd);
> +
> + xhci->quirks |= XHCI_RESET_ON_RESUME;
> + return 0;
> +}
> +
> diff --git a/drivers/usb/host/xhci-brcm.h b/drivers/usb/host/xhci-brcm.h
> new file mode 100644
> index 000000000000..e64800fae4d5
> --- /dev/null
> +++ b/drivers/usb/host/xhci-brcm.h
> @@ -0,0 +1,16 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/* Copyright (c) 2018, Broadcom */
> +
> +#ifndef _XHCI_BRCM_H
> +#define _XHCI_BRCM_H
> +
> +#if IS_ENABLED(CONFIG_USB_XHCI_BRCM)
> +int xhci_plat_brcm_init_quirk(struct usb_hcd *hcd);
> +#else
> +static inline int xhci_plat_brcm_init_quirk(struct usb_hcd *hcd)
> +{
> + return 0;
> +}
> +#endif
> +#endif /* _XHCI_BRCM_H */
> +
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index 315b4552693c..3e90a1207803 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -22,6 +22,7 @@
>
> #include "xhci.h"
> #include "xhci-plat.h"
> +#include "xhci-brcm.h"
> #include "xhci-mvebu.h"
> #include "xhci-rcar.h"
>
> @@ -112,6 +113,10 @@ static const struct xhci_plat_priv xhci_plat_renesas_rcar_gen3 = {
> SET_XHCI_PLAT_PRIV_FOR_RCAR(XHCI_RCAR_FIRMWARE_NAME_V3)
> };
>
> +static const struct xhci_plat_priv xhci_plat_brcm = {
> + .init_quirk = xhci_plat_brcm_init_quirk,
> +};
> +
> static const struct of_device_id usb_xhci_of_match[] = {
> {
> .compatible = "generic-xhci",
> @@ -147,6 +152,12 @@ static const struct of_device_id usb_xhci_of_match[] = {
> }, {
> .compatible = "renesas,rcar-gen3-xhci",
> .data = &xhci_plat_renesas_rcar_gen3,
> + }, {
> + .compatible = "brcm,xhci-brcm-v2",
> + .data = &xhci_plat_brcm,
This one is not described in dt-binding.
> + }, {
> + .compatible = "brcm,bcm7445-xhci",
> + .data = &xhci_plat_brcm,
bcm7445 is a SoC name ?
the quirk only happens on this one? or on all SoCs with Broadcom xHIC
IP?
> },
> {},
> };
next prev parent reply other threads:[~2020-03-30 2:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 20:47 [PATCH v2 0/4] Add XHCI, EHCI and OHCI support for Broadcom STB SoS's Al Cooper
2020-03-27 20:47 ` [PATCH v2 1/4] dt-bindings: Add Broadcom STB USB support Al Cooper
2020-03-30 15:40 ` Rob Herring
2020-04-07 20:28 ` Florian Fainelli
2020-04-08 13:13 ` Alan Cooper
2020-04-08 17:24 ` Florian Fainelli
2020-03-27 20:47 ` [PATCH v2 2/4] usb: xhci: xhci-plat: Add support for Broadcom STB SoC's Al Cooper
2020-03-30 2:35 ` Chunfeng Yun [this message]
2020-04-06 15:28 ` Alan Cooper
2020-03-31 9:37 ` Mathias Nyman
2020-03-27 20:47 ` [PATCH v2 3/4] usb: ehci: Add new EHCI driver " Al Cooper
2020-03-28 0:38 ` Alan Stern
2020-03-28 20:18 ` Andy Shevchenko
2020-04-06 18:46 ` Alan Cooper
2020-03-27 20:47 ` [PATCH v2 4/4] usb: host: Add ability to build new Broadcom STB USB drivers Al Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1585535724.28859.18.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=alcooperx@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=j.neuschaefer@gmx.net \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).