From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D883C2D0A3 for ; Fri, 6 Nov 2020 08:14:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3ABA7208FE for ; Fri, 6 Nov 2020 08:14:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726264AbgKFIOm (ORCPT ); Fri, 6 Nov 2020 03:14:42 -0500 Received: from smtp.radex.nl ([178.250.146.7]:59223 "EHLO radex-web.radex.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726027AbgKFIOm (ORCPT ); Fri, 6 Nov 2020 03:14:42 -0500 Received: from [10.8.0.6] (cust-178-250-146-69.breedbanddelft.nl [178.250.146.69]) by radex-web.radex.nl (Postfix) with ESMTPS id 82F502406A; Fri, 6 Nov 2020 09:14:40 +0100 (CET) Subject: Re: BUG with linux 5.9.0 with dwc3 in gadget mode To: Felipe Balbi , Andy Shevchenko Cc: "linux-usb@vger.kernel.org" , Thinh Nguyen , Heikki Krogerus , Jack Pham References: <913dccca-500d-1938-b199-6eb67cfb60cc@gmail.com> <87a6wig461.fsf@kernel.org> <874kmpf583.fsf@kernel.org> <976cea12-e54e-fbca-6c53-e6ef5c554094@synopsys.com> <645b6ddc-d4f5-3f5b-b85f-b3d27fc365f5@synopsys.com> <2b6586e6-528c-86e8-9d92-0061bc44866d@gmail.com> <2cc783ac-6b71-190b-49fc-9e2bceeacd4b@gmail.com> <920590dc-5430-7f8b-b2e1-1a4c37f4dfbe@synopsys.com> <0089306e-e2ca-9a53-6ffb-202d028050ce@gmail.com> <30ab00e4-53ae-fd9e-1689-c94078a31625@gmail.com> <871rhin1yt.fsf@kernel.org> <87eel7q9bk.fsf@kernel.org> From: Ferry Toth Message-ID: <158f98cc-0aac-f203-41ad-04f927bf58d0@gmail.com> Date: Fri, 6 Nov 2020 09:14:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <87eel7q9bk.fsf@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Op 06-11-2020 om 07:38 schreef Felipe Balbi: > Hi, > > Ferry Toth writes: >> Hi, >> >> Op 28-10-2020 om 10:18 schreef Felipe Balbi: >>> Hi, >>> >>> Ferry Toth writes: >>>> Op 27-10-2020 om 22:16 schreef Andy Shevchenko: >>>>> On Tue, Oct 27, 2020 at 10:13 PM Ferry Toth wrote: >>>>>> Op 22-10-2020 om 15:43 schreef Andy Shevchenko: >>>>>>> On Thu, Oct 22, 2020 at 4:21 PM Thinh Nguyen wrote: >>>>>>>> Ferry Toth wrote: >>>>> ... >>>>> >>>>>>>> There are some fixes to dwc3 in kernel mainline. Is it possible to test >>>>>>>> this against linux-next? >>>>>>> I think the best is to wait for v5.10-rc1 and retest. >>>>> Can you give a try of v5.10-rc1? >>>> Yes, I just tried: >>>> >>>> I booted in host mode, then flip the switch. Gadget come up, go down >>>> once, then come up again and stay up. >>> please collect trace events. It's important to figure out why it's going >>> down, even if only once. Make sure to collect trace *and* dmesg so we >>> can correlate trace with the reenumeration that should show up in dmesg. >>> >>> thanks >> Sorry, I had to replace mobo. Now back on this. >> >> As is, on Edison I can record with something like "perf record -e >> 'dwc3:dwc3_gadget*' -e 'gadget:*' -g -a". >> Then get the trace buffer with "perf script > gadget.txt". Then at each >> trace point we get a stack trace like: >> >> file-storage   831 [001]  4445.240038: dwc3:dwc3_gadget_ep_cmd: [FAILED >> TO PARSE] name=ep4in cmd=524295 param0=0 param1=0 param2=0 cmd_status=0 >>     ffffffff9a35b7e7 __traceiter_dwc3_gadget_ep_cmd+0x37 >> ([kernel.kallsyms]) >>     ffffffff9a35b7e7 __traceiter_dwc3_gadget_ep_cmd+0x37 >> ([kernel.kallsyms]) >>     ffffffff9a35fa40 dwc3_send_gadget_ep_cmd+0x320 ([kernel.kallsyms]) >>     ffffffff9a3606d0 __dwc3_gadget_kick_transfer+0x200 ([kernel.kallsyms]) >>     ffffffff9a361114 dwc3_gadget_ep_queue+0xe4 ([kernel.kallsyms]) >>     ffffffff9a3afc3a usb_ep_queue+0x2a ([kernel.kallsyms]) >>     ffffffffc047c301 start_transfer.isra.0+0x21 ([kernel.kallsyms]) >>     ffffffffc047c88a start_in_transfer.isra.0+0x3a ([kernel.kallsyms]) >>     ffffffffc047c93d send_status+0x8d ([kernel.kallsyms]) >>     ffffffffc047dd05 fsg_main_thread+0x3c5 ([kernel.kallsyms]) >>     ffffffff99c853b9 kthread+0xf9 ([kernel.kallsyms]) >>     ffffffff99c01a32 ret_from_fork+0x22 ([kernel.kallsyms]) >> >> "perf list" shows the tracepoint events, the same as under >> /sys/kernel/debug/tracing/events/ >> >> Question is which points to trace (above command fills buffer to 35MB in >> 10sec). Do you have suggestions? > don't enable any gadget event. Only dwc3 events. Also, enable *all* dwc3 > events. Usually, I avoid perf when doing this and just go straight to > /sys/kernel/trace/. > Ok, I can do that. But I'm not sure how I turn on tracing and capture the results.