linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Oliver Neukum <oneukum@suse.com>
To: Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: ttyACM: disabled by hub (EMI?), re-enabling... Causes garbage chars & disconnect
Date: Tue, 26 May 2020 12:14:44 +0200	[thread overview]
Message-ID: <1590488084.2838.34.camel@suse.com> (raw)
In-Reply-To: <8cf71160e703a18b28d27a844406d42f6cadf39b.camel@infinera.com>

Am Dienstag, den 26.05.2020, 08:59 +0000 schrieb Joakim Tjernlund:
> On Tue, 2020-05-26 at 10:47 +0200, Oliver Neukum wrote:
> > 
> > Am Montag, den 25.05.2020, 16:49 +0000 schrieb Joakim Tjernlund:
> > 
> > > To be clear, I can pull the cable and put it back and there are no garbage chars.
> > > There is also this error:
> > > [Wed May 20 14:03:25 2020] cdc_acm 1-6.3:1.1: acm_ctrl_irq - usb_submit_urb failed: -19
> > > [Wed May 20 14:03:25 2020] usb 1-6-port2: attempt power cycle
> > > [Wed May 20 14:03:26 2020] usb 1-6.3: USB disconnect, device number 86
> > > [Wed May 20 14:03:26 2020] cdc_acm 1-6.3:1.1: failed to set dtr/rts
> > > 
> > > Should not this auto reenable emulate reattaching the USB cable?
> > 
> > Hi,
> > 
> > yes it should. You find the garage characters after the EMI event. How
> > sure are you that they arrive after the event and not during the event?
> > 
> 
> Don't known how to determine that? 
> I can say that 
>    acm_ctrl_irq - usb_submit_urb failed: -19

-19 is -ENODEV

The driver thinks tries to resubmit the URB asking for control
messages.
Basically you are seeing error handling starting and failing due
to a subsequent disconnect.
 
> and
>    cdc_acm 1-6.3:1.1: failed to set dtr/rts
> are unique to this EMI event though. It does not feel like this
> reenabling follow the same procedure as a cable pull?
> As I can only see the above two errors I think we should get rid of
> these first.

The timing is different and if there is EMI transfer can end
in errors and cause error handling to kick in. You are seeing
symptoms. You can try enabling dynamic debugging to get
a better log.

	Regards
		Oliver


  reply	other threads:[~2020-05-26 10:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-25 14:46 ttyACM: disabled by hub (EMI?), re-enabling... Causes garbage chars & disconnect Joakim Tjernlund
2020-05-25 15:02 ` Oliver Neukum
2020-05-25 15:15   ` Joakim Tjernlund
2020-05-25 16:49     ` Joakim Tjernlund
2020-05-26  8:47       ` Oliver Neukum
2020-05-26  8:59         ` Joakim Tjernlund
2020-05-26 10:14           ` Oliver Neukum [this message]
2020-05-26 16:46             ` Joakim Tjernlund
2020-05-26 17:19               ` Joakim Tjernlund
2020-05-27  8:38                 ` Oliver Neukum
2020-05-27  9:40                   ` Joakim Tjernlund
2020-05-27 10:12                     ` Greg KH
2020-05-27 10:41                     ` Oliver Neukum
2020-05-27 13:16                       ` Joakim Tjernlund
2020-05-27 15:41                         ` Joakim Tjernlund
2020-06-05 10:09                           ` Joakim Tjernlund
2020-06-08  9:13                             ` Oliver Neukum
2020-06-08 11:39                               ` Joakim Tjernlund
2020-06-08 15:40                                 ` Oliver Neukum
2020-06-08 16:00                                   ` Joakim Tjernlund
2020-06-08 19:21                                     ` Oliver Neukum
2020-06-15 11:01           ` Joakim Tjernlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1590488084.2838.34.camel@suse.com \
    --to=oneukum@suse.com \
    --cc=Joakim.Tjernlund@infinera.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).