From: Krzysztof Kozlowski <krzk@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>
Cc: Guenter Roeck <linux@roeck-us.net>,
taehyun cho <taehyun.cho@samsung.com>,
Felipe Balbi <balbi@kernel.org>,
USB list <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent
Date: Wed, 3 Mar 2021 17:50:31 +0100 [thread overview]
Message-ID: <159d72a6-e200-913f-6ec1-4668db797a04@kernel.org> (raw)
In-Reply-To: <a6ac3887-38d0-48f4-e06f-81b45484a54a@kernel.org>
On 03/03/2021 17:49, Krzysztof Kozlowski wrote:
>> And "new drivers" are almost always not really "new" as everyone uses
>> much the same IP blocks. As proof of this patch where the DWC3 IP block
>> is being used by multiple SoC vendors. To handle that, you split out
>> the SoC-specific portions into sub-drivers, so that you can build a
>> single image of the driver that works on multiple platforms. Nothing
>> new, we've been doing this for years, it's just that out-of-mainline SoC
>> trees that think they can touch "core IP block code" break this all the
>> time, which is what I am pushing back on.
>
> I am perfectly fine with (and like it!) putting dwc3 exynos back into
> base/main dwc3 and getting rid of USB_DWC3_EXYNOS entirely. But this
> was not part of this patch...
>
>>
>> Anyway, this is just me as a driver subsystem maintainer being grumpy to
>> see ARCH_ dependancies on tiny little things like SoC-portions for
>> generic IP drivers. Or on individual drivers (i.e. Samsung serial port
>> driver), where they don't belong at all.
>
> At least with Samsung serial driver we see adding new SoC - Apple M1.
>
> Here, the guys in Samsung want to tweak several kernel parts to work
> with their out-of-tree code without contributing this code back. It's
> not a community-friendly approach. The upstream kernel should be tweaked
> to the out-of-tree unknown, hidden and uncontrollable code.
Eh, obviously I wanted to say:
The upstream kernel should *not* be tweaked to the out-of-tree unknown,
hidden and uncontrollable code.
>
> Instead I expect from Samsung to contribute the basic Exynos9 support to
> the upstream.
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-03-04 0:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210303022537epcas2p1b85ab825ceca3a411a177cc1af8a2c7b@epcas2p1.samsung.com>
2021-03-03 2:26 ` [PATCH] usb: dwc3: make USB_DWC3_EXYNOS independent taehyun cho
2021-03-03 10:24 ` Krzysztof Kozlowski
2021-03-03 10:30 ` Greg Kroah-Hartman
2021-03-03 10:38 ` Krzysztof Kozlowski
2021-03-03 11:01 ` Krzysztof Kozlowski
2021-03-03 12:54 ` Arnd Bergmann
2021-03-03 14:05 ` Greg Kroah-Hartman
2021-03-03 14:56 ` Guenter Roeck
2021-03-03 15:09 ` Greg Kroah-Hartman
2021-03-03 15:46 ` Krzysztof Kozlowski
2021-03-03 16:33 ` Arnd Bergmann
2021-03-03 16:43 ` Greg Kroah-Hartman
2021-03-03 16:49 ` Krzysztof Kozlowski
2021-03-03 16:50 ` Krzysztof Kozlowski [this message]
2021-03-03 16:56 ` Greg Kroah-Hartman
2021-03-03 19:40 ` Arnd Bergmann
2021-03-03 15:44 ` Krzysztof Kozlowski
2021-03-03 17:51 ` Arnd Bergmann
2021-03-03 13:12 ` taehyun cho
2021-03-03 13:15 ` Krzysztof Kozlowski
[not found] <taehyun cho>
[not found] ` <CGME20210208112816epcas2p43777bb9740f7307e38cb534f01099126@epcas2p4.samsung.com>
2021-02-08 11:29 ` taehyun cho
2021-02-08 11:39 ` Greg Kroah-Hartman
[not found] ` <CGME20210208114447epcas2p3507f22a555355ac7710c5ca220853e0e@epcas2p3.samsung.com>
2021-02-08 11:45 ` taehyun cho
2021-02-08 11:57 ` Greg Kroah-Hartman
2021-02-08 13:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=159d72a6-e200-913f-6ec1-4668db797a04@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=taehyun.cho@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).