From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: usb: add properties for hard wired devices
Date: Tue, 13 Oct 2020 15:34:27 +0800 [thread overview]
Message-ID: <1602574467.29336.64.camel@mhfsdcap03> (raw)
In-Reply-To: <20201012160038.GA1618651@bogus>
On Mon, 2020-10-12 at 11:00 -0500, Rob Herring wrote:
> On Sat, Oct 10, 2020 at 04:43:12PM +0800, Chunfeng Yun wrote:
> > Add some optional properties which are needed for hard wired devices
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > v2 changes suggested by Rob:
> > 1. modify pattern to support any USB class
> > 2. refer to usb-device.yaml instead of usb-device.txt
> > ---
> > .../devicetree/bindings/usb/usb-hcd.yaml | 19 +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
>
> You can fold this into the first patch. While not explicit before, it
> was implied.
Ok
>
> Rob
>
> >
> > diff --git a/Documentation/devicetree/bindings/usb/usb-hcd.yaml b/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > index 7263b7f2b510..42b295afdf32 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > +++ b/Documentation/devicetree/bindings/usb/usb-hcd.yaml
> > @@ -22,9 +22,28 @@ properties:
> > description:
> > Name specifier for the USB PHY
> >
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > +patternProperties:
> > + "^[a-f]+@[0-9a-f]+$":
>
> Just define the unit-address here: "@[0-9a-f]+$"
When I define it as "@[0-9a-f]+$", there is error:
"usb-hcd.example.dt.yaml: usb: hub@1: 'compatile' is a required
property"
> > + type: object
> > + $ref: /usb/usb-device.yaml
> > + description: The hard wired USB devices
>
> Need to also define 'reg' and 'compatible' here.
'reg' and 'compatible' are already defined in usb-device.yaml
>
> > +
> > examples:
> > - |
> > usb {
> > phys = <&usb2_phy1>, <&usb3_phy1>;
> > phy-names = "usb";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + hub@1 {
> > + compatible = "usb5e3,610";
> > + reg = <1>;
> > + };
> > };
> > --
> > 2.18.0
next prev parent reply other threads:[~2020-10-13 7:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-10 8:43 [PATCH v2 1/4] dt-bindings: usb: convert usb-device.txt to YAML schema Chunfeng Yun
2020-10-10 8:43 ` [PATCH v2 2/4] dt-bindings: usb: add properties for hard wired devices Chunfeng Yun
2020-10-12 16:00 ` Rob Herring
2020-10-13 7:34 ` Chunfeng Yun [this message]
2020-10-10 8:43 ` [PATCH v2 3/4] dt-bindings: net: btusb: change reference file name Chunfeng Yun
2020-10-10 8:43 ` [PATCH v2 4/4] dt-bindings: usb: use preferred license tag Chunfeng Yun
2020-10-10 9:50 ` Greg Kroah-Hartman
2020-10-12 1:25 ` Chunfeng Yun
2020-10-12 15:34 ` [PATCH v2 1/4] dt-bindings: usb: convert usb-device.txt to YAML schema Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602574467.29336.64.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).