From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Greg KH <greg@kroah.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alexander Tsoy <alexander@tsoy.me>,
Nicola Lunghi <nick83ola@gmail.com>,
"Christopher Swenson" <swenson@swenson.io>,
Nick Kossifidis <mickflemm@gmail.com>,
<alsa-devel@alsa-project.org>, Ainge Hsu <ainge.hsu@mediatek.com>,
Eddie Hung <eddie.hung@mediatek.com>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Mediatek WSD Upstream <wsd_upstream@mediatek.com>,
Macpaul Lin <macpaul@gmail.com>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-usb@vger.kernel.org>, <linux-mediatek@lists.infradead.org>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v2] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET
Date: Tue, 10 Nov 2020 16:54:29 +0800 [thread overview]
Message-ID: <1604998469.2817.3.camel@mtkswgap22> (raw)
In-Reply-To: <X6pUaatZ7aML4sKq@kroah.com>
On Tue, 2020-11-10 at 09:50 +0100, Greg KH wrote:
> On Tue, Nov 10, 2020 at 04:42:54PM +0800, Macpaul Lin wrote:
> > The HUAWEI USB-C headset (VID:0x12d1, PID:0x3a07) reported it supports
> > 96khz. However there will be some random issue under 96khz.
> > Not sure if there is any alternate setting could be applied.
> > Hence 48khz is suggested to be applied at this moment.
> >
> > Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> > Signed-off-by: Eddie Hung <eddie.hung@mediatek.com>
> > Cc: stable@vger.kernel.org
> > ---
> > Changes for v2:
> > - Fix build error.
> > - Add Cc: stable@vger.kernel.org
> >
> > sound/usb/format.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/sound/usb/format.c b/sound/usb/format.c
> > index 1b28d01..7a4837b 100644
> > --- a/sound/usb/format.c
> > +++ b/sound/usb/format.c
> > @@ -202,6 +202,7 @@ static int parse_audio_format_rates_v1(struct snd_usb_audio *chip, struct audiof
> > fp->rate_min = fp->rate_max = 0;
> > for (r = 0, idx = offset + 1; r < nr_rates; r++, idx += 3) {
> > unsigned int rate = combine_triple(&fmt[idx]);
> > + struct usb_device *udev = chip->dev;
> > if (!rate)
> > continue;
> > /* C-Media CM6501 mislabels its 96 kHz altsetting */
>
> Did you run this patch through checkpatch.pl?
>
I've ran checkpatch for this patch v2, and it shown
"total: 0 errors, 0 warnings". We're using 5.9-rc1 internal.
However, I'll send patch v3 according to Takashi's suggestion.
Thanks
Macpaul Lin
prev parent reply other threads:[~2020-11-10 8:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 8:04 [PATCH] ALSA: usb-audio: disable 96khz support for HUAWEI USB-C HEADSET Macpaul Lin
2020-11-10 8:12 ` Takashi Iwai
2020-11-10 8:17 ` Macpaul Lin
2020-11-10 8:24 ` Takashi Iwai
2020-11-10 9:04 ` [PATCH v3] " Macpaul Lin
2020-11-18 5:26 ` Macpaul Lin
2020-11-18 7:34 ` Takashi Iwai
2020-11-10 8:42 ` [PATCH v2] " Macpaul Lin
2020-11-10 8:50 ` Greg KH
2020-11-10 8:54 ` Macpaul Lin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604998469.2817.3.camel@mtkswgap22 \
--to=macpaul.lin@mediatek.com \
--cc=ainge.hsu@mediatek.com \
--cc=alexander@tsoy.me \
--cc=alsa-devel@alsa-project.org \
--cc=chunfeng.yun@mediatek.com \
--cc=eddie.hung@mediatek.com \
--cc=greg@kroah.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul@gmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mickflemm@gmail.com \
--cc=nick83ola@gmail.com \
--cc=perex@perex.cz \
--cc=stable@vger.kernel.org \
--cc=swenson@swenson.io \
--cc=tiwai@suse.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).