From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Sergei Shtylyov <sergei.shtylyov@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Min Guo <min.guo@mediatek.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-usb@vger.kernel.org>
Subject: Re: [PATCH next 11/15] arm64: dts: mediatek: mt7622: harmonize node names and compatibles
Date: Tue, 19 Jan 2021 10:45:42 +0800 [thread overview]
Message-ID: <1611024342.11995.14.camel@mhfsdcap03> (raw)
In-Reply-To: <8f859d54-f9f8-d7c9-db66-89860124b539@gmail.com>
On Sat, 2021-01-16 at 12:36 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 16.01.2021 12:06, Chunfeng Yun wrote:
>
> > This is used to fix dtbs_check warning
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > index 5b9ec032ce8d..4cfa09b0ca3c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> > @@ -740,8 +740,8 @@
> > status = "disabled";
> > };
> >
> > - u3phy: usb-phy@1a0c4000 {
> > - compatible = "mediatek,mt7622-u3phy",
> > + u3phy: t-phy@1a0c4000 {
>
> What is "t-phy"? Perhaps you should have used just "phy" here...
At first I use "phy", but it causes dt_binding_check fail:
"'#phy-cells' is a required property"
Due to we only need add '#phy-cells' for each subnode (usb-phy, pcie-phy
or sata-phy), but not for parent one, I change the parent node name as
"t-phy" which is a glue layer node, not a real phy.
I also prefer to "phy", but seems dt_binding_check can't distinguish
this case.
Thanks
>
> > + compatible = "mediatek,mt7622-tphy",
> > "mediatek,generic-tphy-v1";
> > reg = <0 0x1a0c4000 0 0x700>;
> > #address-cells = <2>;
> > @@ -875,8 +875,9 @@
> > status = "disabled";
> > };
> >
> > - sata_phy: sata-phy@1a243000 {
> > - compatible = "mediatek,generic-tphy-v1";
> > + sata_phy: t-phy@1a243000 {
>
> Same here...
>
> > + compatible = "mediatek,mt7622-tphy",
> > + "mediatek,generic-tphy-v1";
> > #address-cells = <2>;
> > #size-cells = <2>;
> > ranges;
>
> MBR, Sergei
next prev parent reply other threads:[~2021-01-19 2:46 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-16 9:06 [PATCH next 01/15] dt-bindings: usb: fix yamllint check warning Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 02/15] dt-bindings: usb: mediatek: " Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 03/15] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence Chunfeng Yun
2021-01-18 14:56 ` Chun-Kuang Hu
2021-01-19 2:56 ` Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 04/15] dt-bindings: phy: mediatek: hdmi-phy: modify compatible items Chunfeng Yun
2021-01-18 15:05 ` Chun-Kuang Hu
2021-01-19 2:57 ` Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 05/15] dt-bindings: phy: mediatek: tphy: change patternProperties Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 06/15] dt-bindings: usb: mtk-xhci: add support mt2701 and mt7623 Chunfeng Yun
2021-02-08 21:55 ` Rob Herring
2021-01-16 9:06 ` [PATCH next 07/15] dt-bindings: usb: mediatek: musb: add mt8516 compatbile Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 08/15] arm64: dts: mediatek: mt8173: fix dtbs_check warning Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 09/15] arm64: dts: mediatek: mt2712: harmonize node names Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 10/15] arm64: dts: mediatek: mt8516: harmonize node names and compatibles Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 11/15] arm64: dts: mediatek: mt7622: " Chunfeng Yun
2021-01-16 9:36 ` Sergei Shtylyov
2021-01-19 2:45 ` Chunfeng Yun [this message]
2021-01-16 9:06 ` [PATCH next 12/15] arm64: dts: mediatek: mt8183: fix dtbs_check warning Chunfeng Yun
2021-01-16 9:43 ` Sergei Shtylyov
2021-01-19 2:55 ` Chunfeng Yun
2021-01-17 1:58 ` Nicolas Boichat
2021-01-17 5:42 ` Nicolas Boichat
2021-01-16 9:06 ` [PATCH next 13/15] arm: dts: mt7629: harmonize node names and compatibles Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 14/15] arm: dts: mt7623: " Chunfeng Yun
2021-01-16 9:06 ` [PATCH next 15/15] arm: dts: mt2701: " Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611024342.11995.14.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=chunkuang.hu@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).