From: Longfang Liu <liulongfang@huawei.com>
To: <gregkh@linuxfoundation.org>, <mathias.nyman@intel.com>
Cc: <linux-usb@vger.kernel.org>, <yisen.zhuang@huawei.com>,
<linux-kernel@vger.kernel.org>
Subject: [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller
Date: Fri, 26 Feb 2021 16:21:37 +0800 [thread overview]
Message-ID: <1614327697-1021-1-git-send-email-liulongfang@huawei.com> (raw)
Our current XHCI hardware controller has been customized to only
support USB 2.0 ports. When using the current xhci driver, an xhci
controller device and an ehci controller device will be created
automatically. We want the driver to create only one ehci controller.
After modifying the driver as follows, an error will occur.
Is there any other modification method?
Signed-off-by: Longfang Liu <liulongfang@huawei.com>
---
drivers/usb/host/xhci-pci.c | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index ef513c2..7296aad 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -364,26 +364,15 @@ static int xhci_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
/* USB 2.0 roothub is stored in the PCI device now. */
hcd = dev_get_drvdata(&dev->dev);
xhci = hcd_to_xhci(hcd);
- xhci->shared_hcd = usb_create_shared_hcd(&xhci_pci_hc_driver, &dev->dev,
- pci_name(dev), hcd);
- if (!xhci->shared_hcd) {
- retval = -ENOMEM;
- goto dealloc_usb2_hcd;
- }
-
+ xhci->shared_hcd = NULL;
retval = xhci_ext_cap_init(xhci);
if (retval)
goto put_usb3_hcd;
- retval = usb_add_hcd(xhci->shared_hcd, dev->irq,
+ retval = usb_add_hcd(xhci->main_hcd, dev->irq,
IRQF_SHARED);
if (retval)
goto put_usb3_hcd;
- /* Roothub already marked as USB 3.0 speed */
-
- if (!(xhci->quirks & XHCI_BROKEN_STREAMS) &&
- HCC_MAX_PSA(xhci->hcc_params) >= 4)
- xhci->shared_hcd->can_do_streams = 1;
/* USB-2 and USB-3 roothubs initialized, allow runtime pm suspend */
pm_runtime_put_noidle(&dev->dev);
--
2.8.1
next reply other threads:[~2021-02-26 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 8:21 Longfang Liu [this message]
2021-02-26 8:38 ` [RFC PATCH] USB:XHCI:Modify XHCI driver for USB2.0 controller Greg KH
2021-02-27 3:31 ` liulongfang
2021-03-04 1:35 ` Peter Chen
2021-03-04 4:08 ` liulongfang
2021-02-26 9:22 ` Mathias Nyman
2021-02-27 3:34 ` liulongfang
2021-02-26 16:30 ` Alan Stern
2021-02-27 3:38 ` liulongfang
2021-02-27 3:48 ` liulongfang
2021-02-27 16:27 ` Alan Stern
2021-03-01 1:58 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1614327697-1021-1-git-send-email-liulongfang@huawei.com \
--to=liulongfang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).