From: Li Jun <jun.li@nxp.com>
To: gregkh@linuxfoundation.org, balbi@kernel.org
Cc: linux-usb@vger.kernel.org, jun.li@nxp.com
Subject: [PATCH v2] usb: dwc3: core: don't enable wakeup for runtime PM
Date: Wed, 24 Mar 2021 13:18:25 +0800 [thread overview]
Message-ID: <1616563105-28565-1-git-send-email-jun.li@nxp.com> (raw)
Don't enable dwc3 core to wakeup system by default if runtime suspended,
this will make the power domain of dwc3 core or its parent device can't be
off while system sleep even system wakeup by usb is not required.
Fixes: fc8bb91bc83e ("usb: dwc3: implement runtime PM")
Cc: <Stable@vger.kernel.org>
Signed-off-by: Li Jun <jun.li@nxp.com>
---
Change for v2:
- Add fix tag and cc to stable kernel.
drivers/usb/dwc3/core.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
index 94fdbe502ce9..0bba5c21de56 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1840,8 +1840,6 @@ static int dwc3_runtime_suspend(struct device *dev)
if (ret)
return ret;
- device_init_wakeup(dev, true);
-
return 0;
}
@@ -1850,8 +1848,6 @@ static int dwc3_runtime_resume(struct device *dev)
struct dwc3 *dwc = dev_get_drvdata(dev);
int ret;
- device_init_wakeup(dev, false);
-
ret = dwc3_resume_common(dwc, PMSG_AUTO_RESUME);
if (ret)
return ret;
--
2.25.1
next reply other threads:[~2021-03-24 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 5:18 Li Jun [this message]
2021-03-26 13:38 ` [PATCH v2] usb: dwc3: core: don't enable wakeup for runtime PM Greg KH
2021-03-27 16:07 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616563105-28565-1-git-send-email-jun.li@nxp.com \
--to=jun.li@nxp.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).