From: Manish Narani <manish.narani@xilinx.com>
To: <gregkh@linuxfoundation.org>, <michal.simek@xilinx.com>,
<balbi@kernel.org>
Cc: <git@xilinx.com>, <linux-usb@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Manish Narani <manish.narani@xilinx.com>
Subject: [PATCH 2/2] usb: dwc3: xilinx: Remove the extra freeing of clocks
Date: Thu, 8 Apr 2021 23:24:08 +0530 [thread overview]
Message-ID: <1617904448-74611-3-git-send-email-manish.narani@xilinx.com> (raw)
In-Reply-To: <1617904448-74611-1-git-send-email-manish.narani@xilinx.com>
The clocks are configured by devm_clk_bulk_get_all() in this driver. In
case of any error the clocks freeing will be handled automatically.
There is no need to explicitly free the clocks. Fix the same.
Fixes: 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
---
drivers/usb/dwc3/dwc3-xilinx.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/dwc3-xilinx.c b/drivers/usb/dwc3/dwc3-xilinx.c
index f42f4cb..9cc3ad7 100644
--- a/drivers/usb/dwc3/dwc3-xilinx.c
+++ b/drivers/usb/dwc3/dwc3-xilinx.c
@@ -271,7 +271,6 @@ static int dwc3_xlnx_probe(struct platform_device *pdev)
err_clk_put:
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
- clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
return ret;
}
@@ -284,7 +283,6 @@ static int dwc3_xlnx_remove(struct platform_device *pdev)
of_platform_depopulate(dev);
clk_bulk_disable_unprepare(priv_data->num_clocks, priv_data->clks);
- clk_bulk_put_all(priv_data->num_clocks, priv_data->clks);
priv_data->num_clocks = 0;
pm_runtime_disable(dev);
--
2.1.1
prev parent reply other threads:[~2021-04-08 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 17:54 [PATCH 0/2] Fix for a bug and a kernel-doc warning in Xilinx DWC3 Manish Narani
2021-04-08 17:54 ` [PATCH 1/2] usb: dwc3: Resolve kernel-doc warning for Xilinx DWC3 driver Manish Narani
2021-04-08 17:54 ` Manish Narani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617904448-74611-3-git-send-email-manish.narani@xilinx.com \
--to=manish.narani@xilinx.com \
--cc=balbi@kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).